From: Chunfeng Yun <chunfeng.yun@mediatek.com>
To: Rob Herring <robh@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Felipe Balbi <balbi@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
<linux-usb@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 02/13] dt-bindings: usb: mtu3: add optional property to disable usb2 ports
Date: Tue, 13 Jul 2021 17:00:38 +0800 [thread overview]
Message-ID: <1626166838.29490.4.camel@mhfsdcap03> (raw)
In-Reply-To: <20210712190809.GA2310371@robh.at.kernel.org>
On Mon, 2021-07-12 at 13:08 -0600, Rob Herring wrote:
> On Fri, Jun 18, 2021 at 05:29:07PM +0800, Chunfeng Yun wrote:
> > Add support to disable specific usb2 host ports, it's useful when
> > a usb2 port is disabled on some platforms, but enabled on others for
> > the same SoC, another case is that the different package may support
> > different number of ports.
> >
> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > ---
> > v2: no changes
> > ---
> > Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml b/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
> > index 2cac7a87ce36..3e6f2750f48d 100644
> > --- a/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
> > +++ b/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
> > @@ -166,6 +166,12 @@ properties:
> > description: The mask to disable u3ports, bit0 for u3port0,
> > bit1 for u3port1, ... etc
> >
> > + mediatek,u2p-dis-msk:
>
> Just spell out 'mask'.
There is already a property "mediatek,u3p-dis-msk", prefer to use the
same format, thanks
>
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + description: The mask to disable u2ports, bit0 for u2port0,
> > + bit1 for u2port1, ... etc; but can't disable u2port0 if dual role mode
> > + is enabled, so will be skipped in this case.
> > +
> > # Required child node when support dual-role
> > patternProperties:
> > "^usb@[0-9a-f]+$":
> > --
> > 2.18.0
> >
> >
next prev parent reply other threads:[~2021-07-13 9:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-18 9:29 [PATCH v2 00/13] Add support mtu3 gadget (runtime) PM Chunfeng Yun
2021-06-18 9:29 ` [PATCH v2 01/13] dt-bindings: usb: mtu3: remove support VBUS detection of extcon Chunfeng Yun
2021-07-12 19:07 ` Rob Herring
2021-06-18 9:29 ` [PATCH v2 02/13] dt-bindings: usb: mtu3: add optional property to disable usb2 ports Chunfeng Yun
2021-07-12 19:08 ` Rob Herring
2021-07-13 9:00 ` Chunfeng Yun [this message]
2021-06-18 9:29 ` [PATCH v2 03/13] dt-bindings: usb: mtu3: add support property role-switch-default-mode Chunfeng Yun
2021-07-12 19:08 ` Rob Herring
2021-06-18 9:29 ` [PATCH v2 04/13] dt-bindings: usb: mtu3: add wakeup interrupt Chunfeng Yun
2021-07-12 19:09 ` Rob Herring
2021-06-18 9:29 ` [PATCH v2 05/13] usb: common: add helper to get role-switch-default-mode Chunfeng Yun
2021-06-18 9:29 ` [PATCH v2 06/13] usb: dwc3: drd: use " Chunfeng Yun
2021-06-18 9:29 ` [PATCH v2 07/13] usb: mtu3: support property role-switch-default-mode Chunfeng Yun
2021-06-18 9:29 ` [PATCH v2 08/13] usb: mtu3: support option to disable usb2 ports Chunfeng Yun
2021-06-18 9:29 ` [PATCH v2 09/13] usb: mtu3: add new helpers for host suspend/resume Chunfeng Yun
2021-06-18 9:29 ` [PATCH v2 10/13] usb: mtu3: support runtime PM for host mode Chunfeng Yun
2021-06-18 9:29 ` [PATCH v2 11/13] usb: mtu3: add helper to power on/down device Chunfeng Yun
2021-06-18 9:29 ` [PATCH v2 12/13] usb: mtu3: support suspend/resume for device mode Chunfeng Yun
2021-06-18 9:29 ` [PATCH v2 13/13] usb: mtu3: support suspend/resume for dual-role mode Chunfeng Yun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1626166838.29490.4.camel@mhfsdcap03 \
--to=chunfeng.yun@mediatek.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=balbi@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).