From: patchwork-bot+netdevbpf@kernel.org
To: Pavel Skripkin <paskripkin@gmail.com>
Cc: davem@davemloft.net, kuba@kernel.org, linux@rempel-privat.de,
andrew@lunn.ch, himadrispandya@gmail.com,
robert.foss@collabora.com, freddy@asix.com.tw,
linux-usb@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
syzbot+a631ec9e717fb0423053@syzkaller.appspotmail.com
Subject: Re: [PATCH v4] net: asix: fix uninit value bugs
Date: Wed, 18 Aug 2021 10:50:05 +0000 [thread overview]
Message-ID: <162928380541.20153.5366417098709462761.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20210817163723.19040-1-paskripkin@gmail.com>
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Tue, 17 Aug 2021 19:37:23 +0300 you wrote:
> Syzbot reported uninit-value in asix_mdio_read(). The problem was in
> missing error handling. asix_read_cmd() should initialize passed stack
> variable smsr, but it can fail in some cases. Then while condidition
> checks possibly uninit smsr variable.
>
> Since smsr is uninitialized stack variable, driver can misbehave,
> because smsr will be random in case of asix_read_cmd() failure.
> Fix it by adding error handling and just continue the loop instead of
> checking uninit value.
>
> [...]
Here is the summary with links:
- [v4] net: asix: fix uninit value bugs
https://git.kernel.org/netdev/net/c/a786e3195d6a
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
next prev parent reply other threads:[~2021-08-18 10:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-13 16:01 [PATCH] net: asix: fix uninit value in asix_mdio_read Pavel Skripkin
2021-08-13 22:23 ` Andrew Lunn
2021-08-13 22:29 ` Pavel Skripkin
2021-08-13 22:42 ` [PATCH v2] " Pavel Skripkin
2021-08-13 22:52 ` Jakub Kicinski
2021-08-14 13:55 ` [PATCH v3] net: asix: fix uninit value bugs Pavel Skripkin
2021-08-14 15:36 ` Andrew Lunn
2021-08-14 15:40 ` Pavel Skripkin
2021-08-14 16:20 ` Pavel Skripkin
2021-08-17 16:37 ` [PATCH v4] " Pavel Skripkin
2021-08-18 10:50 ` patchwork-bot+netdevbpf [this message]
2021-08-13 22:57 ` [PATCH v2] net: asix: fix uninit value in asix_mdio_read Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=162928380541.20153.5366417098709462761.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=freddy@asix.com.tw \
--cc=himadrispandya@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=netdev@vger.kernel.org \
--cc=paskripkin@gmail.com \
--cc=robert.foss@collabora.com \
--cc=syzbot+a631ec9e717fb0423053@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).