From: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
To: <hminas@synopsys.com>, <gregkh@linuxfoundation.org>,
<robh+dt@kernel.org>
Cc: <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<devicetree@vger.kernel.org>, <amelie.delaunay@foss.st.com>,
<fabrice.gasnier@foss.st.com>, <alexandre.torgue@foss.st.com>
Subject: [PATCH v3 0/4] usb: dwc2: fill in gadget caps, configure it for stm32mp15
Date: Wed, 13 Oct 2021 15:57:01 +0200 [thread overview]
Message-ID: <1634133425-25670-1-git-send-email-fabrice.gasnier@foss.st.com> (raw)
This patchset fills in 'otg_caps' of the usb_gadget structure, and
configures it on stm32mp15.
When dwc2 is configured as dual role (OTG), the USB gadget descriptors
(device mode) are configured via configfs. This lead in calling
usb_otg_descriptor_init().
In usb_otg_descriptor_init() (drivers/usb/gadget/config.c):
- If otg caps structure is provided -> use it
- If otg caps structure isn't provided -> HNP and SRP are enabled by default
This could lead to a configuration mismatch beetween:
- OTG controller: HNP and SRP aren't enabled
- gadget descriptors: HNP and SRP are advertised
---
Changes in v3:
- Add dt-bindings patch, as adding properties from usb-drd.yaml is
currently not handled in dwc2.yaml. This lead to have
"make dtbs_check" reports errors like:
...'otg-rev' does not match any of the regexes: 'pinctrl-[0-9]+'
From schema: /local/home/fgasni00/baseline/linux-stm32/Documentation/devicetree/bindings/usb/dwc2.yaml
- Could/should the dt-bindings be ported to stable ?
(the DT patch for stm32mp151 in v1 got merged already)
Changes in v2:
- replace otg_cap bit field by otg_caps structure.
- Fix build issue when HOST only mode is selected [1]
- DT patch for stm32mp151 merged in v1, so not resent
[1] https://lore.kernel.org/all/000000000000b01f1505cda8e03c@google.com
Fabrice Gasnier (4):
dt-bindings: usb: dwc2: Add reference to usb-drd.yaml
dt-bindings: usb: dwc2: adopt otg properties defined in usb-drd.yaml
usb: dwc2: add otg_rev and otg_caps information for gadget driver
usb: dwc2: stm32mp15: set otg_rev
Documentation/devicetree/bindings/usb/dwc2.yaml | 16 ++++--
drivers/usb/dwc2/core.h | 19 +++----
drivers/usb/dwc2/debugfs.c | 4 +-
drivers/usb/dwc2/gadget.c | 1 +
drivers/usb/dwc2/hcd.c | 12 ++--
drivers/usb/dwc2/params.c | 75 ++++++++++++++-----------
6 files changed, 70 insertions(+), 57 deletions(-)
--
2.7.4
next reply other threads:[~2021-10-13 13:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-13 13:57 Fabrice Gasnier [this message]
2021-10-13 13:57 ` [PATCH v3 1/4] dt-bindings: usb: dwc2: Add reference to usb-drd.yaml Fabrice Gasnier
2021-10-18 19:19 ` Rob Herring
2021-10-13 13:57 ` [PATCH v3 2/4] dt-bindings: usb: dwc2: adopt otg properties defined in usb-drd.yaml Fabrice Gasnier
2021-10-18 19:19 ` Rob Herring
2021-10-13 13:57 ` [PATCH v3 3/4] usb: dwc2: add otg_rev and otg_caps information for gadget driver Fabrice Gasnier
2021-10-13 13:57 ` [PATCH v3 4/4] usb: dwc2: stm32mp15: set otg_rev Fabrice Gasnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1634133425-25670-1-git-send-email-fabrice.gasnier@foss.st.com \
--to=fabrice.gasnier@foss.st.com \
--cc=alexandre.torgue@foss.st.com \
--cc=amelie.delaunay@foss.st.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hminas@synopsys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-usb@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).