linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc: Peng Fan <peng.fan@nxp.com>,
	s.hauer@pengutronix.de, kernel@pengutronix.de,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-imx@nxp.com, gregkh@linuxfoundation.org,
	festevam@gmail.com, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, shawnguo@kernel.org,
	xu.yang_2@nxp.com, robh+dt@kernel.org, jun.li@nxp.com,
	krzysztof.kozlowski+dt@linaro.org
Subject: Re: [PATCH V4 2/6] dt-bindings: usb: ci-hdrc-usb2: convert to DT schema format
Date: Fri, 17 Mar 2023 09:55:19 -0500	[thread overview]
Message-ID: <167906278443.1989626.14584373898685842817.robh@kernel.org> (raw)
In-Reply-To: <20230317123708.337286-3-peng.fan@oss.nxp.com>


On Fri, 17 Mar 2023 20:37:04 +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> Convert the binding to DT schema format. To fix the dtbs_check
> error, some properties were also added, such as nvidia,phy, reset-names
> ulpi; missing compatibles are added.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  .../devicetree/bindings/usb/ci-hdrc-usb2.txt  | 159 -------
>  .../devicetree/bindings/usb/ci-hdrc-usb2.yaml | 412 ++++++++++++++++++
>  2 files changed, 412 insertions(+), 159 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
>  create mode 100644 Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml: properties:pinctrl-names:items: {'enum': ['default', 'host', 'device', 'idle', 'active']} is not of type 'array'
	from schema $id: http://devicetree.org/meta-schemas/string-array.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230317123708.337286-3-peng.fan@oss.nxp.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  reply	other threads:[~2023-03-17 14:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-17 12:37 [PATCH V4 0/6] dt-bindings: usb: covert ci-hdrc-usb2/usbmisc-imx to yaml Peng Fan (OSS)
2023-03-17 12:37 ` [PATCH V4 1/6] dt-bindings: usb: usbmisc-imx: convert to DT schema Peng Fan (OSS)
2023-03-19 12:19   ` Krzysztof Kozlowski
2023-03-17 12:37 ` [PATCH V4 2/6] dt-bindings: usb: ci-hdrc-usb2: convert to DT schema format Peng Fan (OSS)
2023-03-17 14:55   ` Rob Herring [this message]
2023-03-17 12:37 ` [PATCH V4 3/6] ARM64: dts: imx8mn: update usb compatible Peng Fan (OSS)
2023-03-17 12:37 ` [PATCH V4 4/6] arm64: dts: imx8mm: " Peng Fan (OSS)
2023-03-17 12:37 ` [PATCH V4 5/6] arm64: dts: imx8: " Peng Fan (OSS)
2023-03-17 12:37 ` [PATCH V4 6/6] arm64: dts: imx8dxl: " Peng Fan (OSS)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=167906278443.1989626.14584373898685842817.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jun.li@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=peng.fan@nxp.com \
    --cc=peng.fan@oss.nxp.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=xu.yang_2@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).