From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F22FFC4741F for ; Mon, 28 Sep 2020 19:12:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B7E122073A for ; Mon, 28 Sep 2020 19:12:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726562AbgI1TMO (ORCPT ); Mon, 28 Sep 2020 15:12:14 -0400 Received: from dispatch1-us1.ppe-hosted.com ([67.231.154.164]:37650 "EHLO dispatch1-us1.ppe-hosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726228AbgI1TMO (ORCPT ); Mon, 28 Sep 2020 15:12:14 -0400 X-Greylist: delayed 498 seconds by postgrey-1.27 at vger.kernel.org; Mon, 28 Sep 2020 15:12:13 EDT Received: from dispatch1-us1.ppe-hosted.com (localhost.localdomain [127.0.0.1]) by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 2BF94515BF; Mon, 28 Sep 2020 19:03:56 +0000 (UTC) Received: from mx1-us1.ppe-hosted.com (unknown [10.110.50.137]) by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 77B5C200BF; Mon, 28 Sep 2020 19:03:55 +0000 (UTC) Received: from us4-mdac16-58.at1.mdlocal (unknown [10.110.50.151]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 710D26009B; Mon, 28 Sep 2020 19:03:55 +0000 (UTC) X-Virus-Scanned: Proofpoint Essentials engine Received: from mx1-us1.ppe-hosted.com (unknown [10.110.49.32]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id BDC04220086; Mon, 28 Sep 2020 19:03:54 +0000 (UTC) Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 46E2E28007B; Mon, 28 Sep 2020 19:03:53 +0000 (UTC) Received: from [10.17.20.203] (10.17.20.203) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 28 Sep 2020 20:03:31 +0100 Subject: Re: [patch 15/35] net: sfc: Replace in_interrupt() usage. To: Thomas Gleixner , LKML CC: Peter Zijlstra , Linus Torvalds , Paul McKenney , "Matthew Wilcox" , Sebastian Andrzej Siewior , Solarflare linux maintainers , Martin Habets , "David S. Miller" , Jakub Kicinski , , Christian Benvenuti , Govindarajulu Varadarajan <_govind@gmx.com>, Jonathan Corbet , Mauro Carvalho Chehab , , Luc Van Oostenryck , Jay Cliburn , Chris Snook , Vishal Kulkarni , Jeff Kirsher , , "Shannon Nelson" , Pensando Drivers , Andrew Lunn , Heiner Kallweit , Russell King , Thomas Bogendoerfer , Jon Mason , Daniel Drake , Ulrich Kunitz , Kalle Valo , , , Greg Kroah-Hartman , Arend van Spriel , Franky Lin , "Hante Meuleman" , Chi-Hsien Lin , Wright Feng , , , Stanislav Yakovlev , Stanislaw Gruszka , Johannes Berg , Emmanuel Grumbach , Luca Coelho , "Intel Linux Wireless" , Jouni Malinen , "Amitkumar Karwar" , Ganapathi Bhat , Xinming Hu , , Pascal Terjan , Ping-Ke Shih References: <20200927194846.045411263@linutronix.de> <20200927194921.344476620@linutronix.de> From: Edward Cree Message-ID: <168a1f9e-cba4-69a8-9b29-5c121295e960@solarflare.com> Date: Mon, 28 Sep 2020 20:03:26 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20200927194921.344476620@linutronix.de> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Content-Language: en-GB X-Originating-IP: [10.17.20.203] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.6.1012-25674.003 X-TM-AS-Result: No-3.392600-8.000000-10 X-TMASE-MatchedRID: scwq2vQP8OHoSitJVour/fZvT2zYoYOwC/ExpXrHizwZwGrh4y4izL88 DvjRvF4AxVy/bbd+rAzlMoALbl7BxnAe/yBs2gz+SJA7ysb1rf4KJM4okvH5XoVCSVIDsC6o8FS rkmy6/FJuCEgimCyJQyMYmr0rrl/pgl5Rdh8uTQGz5GTUpcs/m3Fa/hQHt1A1+S5C/08hWc0UBy nKnmzE5ngVNbMoKNzVH0rosakDCyyvvxILmKK/HIMbH85DUZXyYxU/PH+vZxv6C0ePs7A07Y6HM 5rqDwqtN237Af2aNF37I73RKjILsWlTLDIPbPGsLoghHcIpC2/UZWTGDxA33ihvJVwuK5sjeBCY ZbP6cf5T86emsjutggfap7ehBz6Q4vn0zMfSmjYrbLOj1GuP3A+hgLflG6KEo9QjuF9BKnnfMd6 s6DDccQ== X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--3.392600-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.6.1012-25674.003 X-MDID: 1601319835-pcw6fPKCBDdo Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On 27/09/2020 20:49, Thomas Gleixner wrote: > Note, that the fixes tag is empty as it is unclear which of the commits to > blame. Seems like it should be Fixes: f00bf2305cab("sfc: don't update stats on VF when called in atomic context")  since that adds the in_interrupt() check and the code concerned  doesn't seemto have changed a great deal since. Anyway, this fix looks correct, and you can have my Acked-by: Edward Cree  but I thinkit might be cleaner to avoid having to have this unused  can_sleep argument on all the NICs that don't need it, by instead  adding an update_stats_atomic() member to struct efx_nic_type, which  could be set to the same as update_stats() for everything except  EF10 VFs which would just do the call to efx_update_sw_stats(). I'll send an rfc patch embodying the above shortly... -ed