From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>, mathias.nyman@intel.com
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"open list:USB XHCI DRIVER" <linux-usb@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] xhci: Do warm-reset when both CAS and XDEV_RESUME are set
Date: Tue, 11 Aug 2020 11:52:39 +0300 [thread overview]
Message-ID: <171f8ce9-2fdf-9b8b-9dfe-2b24e5a4b1a1@linux.intel.com> (raw)
In-Reply-To: <20200810140753.6639-1-kai.heng.feng@canonical.com>
On 10.8.2020 17.07, Kai-Heng Feng wrote:
> Sometimes re-plugging a USB device during system sleep renders the device
> useless:
> [ 173.418345] xhci_hcd 0000:00:14.0: Get port status 2-4 read: 0x14203e2, return 0x10262
> ...
> [ 176.496485] usb 2-4: Waited 2000ms for CONNECT
> [ 176.496781] usb usb2-port4: status 0000.0262 after resume, -19
> [ 176.497103] usb 2-4: can't resume, status -19
> [ 176.497438] usb usb2-port4: logical disconnect
>
> Because PLS equals to XDEV_RESUME, xHCI driver reports U3 to usbcore,
> despite of CAS bit is flagged.
>
> So proritize CAS over XDEV_RESUME to let usbcore handle warm-reset for
> the port.
>
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> ---
Thanks, nice catch.
Adding to queue
-Mathias
prev parent reply other threads:[~2020-08-11 8:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-10 14:07 [PATCH] xhci: Do warm-reset when both CAS and XDEV_RESUME are set Kai-Heng Feng
2020-08-11 8:52 ` Mathias Nyman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171f8ce9-2fdf-9b8b-9dfe-2b24e5a4b1a1@linux.intel.com \
--to=mathias.nyman@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=kai.heng.feng@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).