From: Amelie DELAUNAY <amelie.delaunay@st.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: Minas Harutyunyan <hminas@synopsys.com>,
Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre TORGUE <alexandre.torgue@st.com>,
USB <linux-usb@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>,
Fabrice GASNIER <fabrice.gasnier@st.com>
Subject: Re: [PATCH v4 3/3] usb: dwc2: don't use ID/Vbus detection if usb-role-switch on STM32MP15 SoCs
Date: Tue, 28 Jul 2020 09:27:37 +0200 [thread overview]
Message-ID: <19ba2fe3-56d1-32a9-3897-27a36ab58c2c@st.com> (raw)
In-Reply-To: <CAHp75Ve75d+K87cokb4YYgim_wU0gTidGuiPs3BmohRKfTh5gA@mail.gmail.com>
Hi,
On 7/27/20 9:44 PM, Andy Shevchenko wrote:
> On Mon, Jul 27, 2020 at 10:04 PM Martin Blumenstingl
> <martin.blumenstingl@googlemail.com> wrote:
>> On Mon, Jul 27, 2020 at 11:23 AM Amelie Delaunay <amelie.delaunay@st.com> wrote:
>
>> > - p->activate_stm_id_vb_detection = true;
>> > + p->activate_stm_id_vb_detection =
>> > + !of_property_read_bool(np, "usb-role-switch");
>> the rest of params.c uses device_property_read_* instead of of_read_property_*
>> I thought I'd mention it so you can decide yourself whether this is
>> fine or needs to be changed
>
> Better to change and leave all on one line.
>
Thank you both for your review. I'll change it in upcoming v5. I'm still
not used to exceed the 80 columns :)
Regards,
Amelie
> --
> With Best Regards,
> Andy Shevchenko
prev parent reply other threads:[~2020-07-28 7:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-27 9:23 [PATCH v4 0/3] Add USB role switch support to DWC2 Amelie Delaunay
2020-07-27 9:23 ` [PATCH v4 1/3] dt-bindings: usb: dwc2: add optional usb-role-switch property Amelie Delaunay
2020-07-27 17:47 ` Martin Blumenstingl
2020-07-27 9:23 ` [PATCH v4 2/3] usb: dwc2: override PHY input signals with usb role switch support Amelie Delaunay
2020-07-27 17:55 ` Martin Blumenstingl
2020-07-27 9:23 ` [PATCH v4 3/3] usb: dwc2: don't use ID/Vbus detection if usb-role-switch on STM32MP15 SoCs Amelie Delaunay
2020-07-27 17:49 ` Martin Blumenstingl
2020-07-27 19:44 ` Andy Shevchenko
2020-07-28 7:27 ` Amelie DELAUNAY [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19ba2fe3-56d1-32a9-3897-27a36ab58c2c@st.com \
--to=amelie.delaunay@st.com \
--cc=alexandre.torgue@st.com \
--cc=andy.shevchenko@gmail.com \
--cc=balbi@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fabrice.gasnier@st.com \
--cc=gregkh@linuxfoundation.org \
--cc=hminas@synopsys.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-usb@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).