archive mirror
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <>
To: Patong Yang <>
Subject: Driver for MaxLinear/Exar USB (UART) Serial Adapters
Date: Thu, 26 Jul 2018 12:57:36 +0200	[thread overview]
Message-ID: <> (raw)

On Tue, Jul 24, 2018 at 03:36:36PM -0700, Patong Yang wrote:
> The original driver/patch was submitted on April 4, 2018.  This is the
> second version based on the feedback received on the original patch.
> v2: Removed custom IOCTLs, as suggested by Greg KH
>     Using standard Linux GPIO APIs, as suggested by Greg KH
>     Removed file reads/writes as suggested by Greg KH
> Signed-off-by: Patong Yang <>
> ---
>  drivers/usb/serial/xrusb_serial.c | 2380 +++++++++++++++++++++++++++++
>  drivers/usb/serial/xrusb_serial.h |  234 +++

Why do you need a .h file for a single driver?  Please just put it all
into one file.

But there is a bigger problem here:

> +	xrusb_tty_driver = alloc_tty_driver(XRUSB_TTY_MINORS);
> +	if (!xrusb_tty_driver)
> +		return -ENOMEM;

Why are you not using the usb serial core here?  You need to do that,
not try to provide your own custom tty driver.  That way userspace
programs will "just work" with your new device, no changes needed as
your major/minor number and device name would be custom only for your
device, which is not acceptable.

By doing that, your code will also be much smaller, always a good
benefit as well.


greg k-h
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to
More majordomo info at

             reply	other threads:[~2018-07-26 10:57 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-26 10:57 Greg Kroah-Hartman [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-08-16 10:05 Driver for MaxLinear/Exar USB (UART) Serial Adapters Greg Kroah-Hartman
2018-08-16  8:28 Patong Yang
2018-08-16  8:26 Oliver Neukum
2018-08-16  6:34 Greg Kroah-Hartman
2018-08-16  5:56 Patong Yang
2018-07-25  7:38 Oliver Neukum
2018-07-24 22:36 Patong Yang
2018-04-06 14:45 Driver for MaxLinear/Exar USB (UART) Serial adapters Greg Kroah-Hartman
2018-04-05  7:38 Oliver Neukum
2018-04-05  6:26 Greg Kroah-Hartman
2018-04-04  8:00 Greg Kroah-Hartman
2018-04-04  7:59 Greg Kroah-Hartman
2018-04-04  7:38 Oliver Neukum
2018-04-04  7:06 Patong Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).