From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Soeren Moch <smoch@web.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alan Stern <stern@rowland.harvard.edu>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] Revert "usb: core: remove local_irq_save() around ->complete() handler"
Date: Sat, 1 Jun 2019 12:50:08 +0200 [thread overview]
Message-ID: <20190601105008.zfqrtu6krw4mhisb@linutronix.de> (raw)
In-Reply-To: <6c03445c-3607-9f33-afee-94613f8d6978@web.de>
On 2019-06-01 01:02:37 [+0200], Soeren Moch wrote:
> > Why not just fix that driver? Wouldn't that be easier?
> >
> I suspect there are more drivers to fix. I only tested WIFI sticks so
> far, RTL8188 drivers also seem to suffer from this. I'm not sure how to
> fix all this properly, maybe Sebastian as original patch author can help
> here.
Suspecting isn't helping here.
> This patch is mostly for -stable, to get an acceptable solution quickly.
> It was really annoying to get such unstable WIFI connection over the
> last three kernel releases to my development board. Since my internet
> service provider forcefully updated my router box 3 weeks ago, I
> unfortunately see the same symptoms on my primary internet access.
> That's even worse, I need to reset this router box every few days. I'm
> not sure, however, that this is caused by the same problem, but it feels
> like this.
> So can we please fix this regression quickly and workout a proper fix
> later? In the original patch there is no reason given, why this patch is
> necessary. With this revert I at least see a stable connection.
I will look into this. This patch got in in v4.20-rc1 and the final
kernel was released by the end of 2018. This is the first report I am
aware of over half year later…
> Thanks,
> Soeren
Sebastian
next prev parent reply other threads:[~2019-06-01 10:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-31 21:53 [PATCH] Revert "usb: core: remove local_irq_save() around ->complete() handler" Soeren Moch
2019-05-31 22:05 ` Greg Kroah-Hartman
2019-05-31 23:02 ` Soeren Moch
2019-06-01 10:50 ` Sebastian Andrzej Siewior [this message]
2019-06-01 11:02 ` Sebastian Andrzej Siewior
2019-06-03 12:50 ` Sören Moch
2019-06-12 10:38 ` Soeren Moch
2019-06-12 14:38 ` Alan Stern
2019-06-12 14:47 ` Sebastian Andrzej Siewior
2019-06-17 10:12 ` Soeren Moch
2019-06-03 12:47 ` Sören Moch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190601105008.zfqrtu6krw4mhisb@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=smoch@web.de \
--cc=stable@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).