[PATCH] Fix chipmunk-like voice when using Logitech C270 for recording audio.

[PATCH] Fix chipmunk-like voice when using Logitech C270 for recording audio.

[Marco Zatta]

This patch fixes the chipmunk-like voice that manifets randomly when
using the integrated mic of the Logitech Webcam HD C270.

The issue was solved initially for this device by commit
2394d67e446bf616a0885167d5f0d397bdacfdfc but it was then reintroduced by
e387ef5c47ddeaeaa3cbdc54424cdb7a28dae2c0. This patch is to have the fix
back.

Signed-off-by: Marco Zatta <marco@zatta.me>
---
 drivers/usb/core/quirks.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index 6082b008969b..6b6413073584 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -215,6 +215,9 @@ static const struct usb_device_id usb_quirk_list[] = {
 	/* Cherry Stream G230 2.0 (G85-231) and 3.0 (G85-232) */
 	{ USB_DEVICE(0x046a, 0x0023), .driver_info = USB_QUIRK_RESET_RESUME },
 
+	/* Logitech HD Webcam C270 */
+	{ USB_DEVICE(0x046d, 0x0825), .driver_info = USB_QUIRK_RESET_RESUME },
+
 	/* Logitech HD Pro Webcams C920, C920-C, C925e and C930e */
 	{ USB_DEVICE(0x046d, 0x082d), .driver_info = USB_QUIRK_DELAY_INIT },
 	{ USB_DEVICE(0x046d, 0x0841), .driver_info = USB_QUIRK_DELAY_INIT },
-- 
2.21.0

Re: [PATCH] Fix chipmunk-like voice when using Logitech C270 for recording audio.

[Sergei Shtylyov]

Hello!

On 01.06.2019 10:52, Marco Zatta wrote:

> This patch fixes the chipmunk-like voice that manifets randomly when
> using the integrated mic of the Logitech Webcam HD C270.
> 
> The issue was solved initially for this device by commit
> 2394d67e446bf616a0885167d5f0d397bdacfdfc but it was then reintroduced by
> e387ef5c47ddeaeaa3cbdc54424cdb7a28dae2c0. This patch is to have the fix

    It's not how you should cite the commits, see below:

<12-digit SHA1> ("<summary>")

> back.
> 
> Signed-off-by: Marco Zatta <marco@zatta.me>
[...]

MBR, Sergei

Re: [PATCH] Fix chipmunk-like voice when using Logitech C270 for recording audio.

[Marco Zatta]

Hi!
On Sat, Jun 01, 2019 at 12:33:06PM +0300, Sergei Shtylyov wrote:
> Hello!
> 
> On 01.06.2019 10:52, Marco Zatta wrote:
> 
> > This patch fixes the chipmunk-like voice that manifets randomly when
> > using the integrated mic of the Logitech Webcam HD C270.
> > 
> > The issue was solved initially for this device by commit
> > 2394d67e446bf616a0885167d5f0d397bdacfdfc but it was then reintroduced by
> > e387ef5c47ddeaeaa3cbdc54424cdb7a28dae2c0. This patch is to have the fix
> 
>    It's not how you should cite the commits, see below:
> 
> <12-digit SHA1> ("<summary>")
> 

You are right, I am sorry about that. The commits are
2394d67e446bf616a0885167d5f0d397bdacfdfc ("USB: add RESET_RESUME for
webcams shown to be quirky") and
e387ef5c47ddeaeaa3cbdc54424cdb7a28dae2c0 ("usb: Add
USB_QUIRK_RESET_RESUME for all Logitech UVC webcams")

> > back.
> > 
> > Signed-off-by: Marco Zatta <marco@zatta.me>
> [...]
> 
> MBR, Sergei

Best regards,
Marco

Re: [PATCH] Fix chipmunk-like voice when using Logitech C270 for recording audio.

[Greg KH]

On Sat, Jun 01, 2019 at 12:11:37PM +0200, Marco Zatta wrote:
> Hi!
> On Sat, Jun 01, 2019 at 12:33:06PM +0300, Sergei Shtylyov wrote:
> > Hello!
> > 
> > On 01.06.2019 10:52, Marco Zatta wrote:
> > 
> > > This patch fixes the chipmunk-like voice that manifets randomly when
> > > using the integrated mic of the Logitech Webcam HD C270.
> > > 
> > > The issue was solved initially for this device by commit
> > > 2394d67e446bf616a0885167d5f0d397bdacfdfc but it was then reintroduced by
> > > e387ef5c47ddeaeaa3cbdc54424cdb7a28dae2c0. This patch is to have the fix
> > 
> >    It's not how you should cite the commits, see below:
> > 
> > <12-digit SHA1> ("<summary>")
> > 
> 
> You are right, I am sorry about that. The commits are
> 2394d67e446bf616a0885167d5f0d397bdacfdfc ("USB: add RESET_RESUME for
> webcams shown to be quirky") and
> e387ef5c47ddeaeaa3cbdc54424cdb7a28dae2c0 ("usb: Add
> USB_QUIRK_RESET_RESUME for all Logitech UVC webcams")

No problem, I'll fix this up when applying the patch next week, thanks!

greg k-h

Re: [PATCH] Fix chipmunk-like voice when using Logitech C270 for recording audio.

[Oliver Neukum]

Am Samstag, den 01.06.2019, 09:52 +0200 schrieb Marco Zatta:
> This patch fixes the chipmunk-like voice that manifets randomly when
> using the integrated mic of the Logitech Webcam HD C270.
> 
> The issue was solved initially for this device by commit
> 2394d67e446bf616a0885167d5f0d397bdacfdfc but it was then reintroduced by
> e387ef5c47ddeaeaa3cbdc54424cdb7a28dae2c0. This patch is to have the fix
> back.

Are you sure only the C270 is affected?

	Regards
		Oliver

Re: [PATCH] Fix chipmunk-like voice when using Logitech C270 for recording audio.

[Marco Zatta]

On Mon, Jun 03, 2019 at 11:58:10AM +0200, Oliver Neukum wrote:
> Are you sure only the C270 is affected?
> 
> 	Regards
> 		Oliver
> 
Hello Oliver,

No, unfortunately I am not sure but I am missing the hardware to
properly test. I am quite sure that it fixes the problem in the C270
though :)
Thanks for that, since you were the author of the first commit.

Bests,
Marco

Re: [PATCH] Fix chipmunk-like voice when using Logitech C270 for recording audio.

[Oliver Neukum]

Am Montag, den 03.06.2019, 19:55 +0200 schrieb Marco Zatta:
> On Mon, Jun 03, 2019 at 11:58:10AM +0200, Oliver Neukum wrote:
> > Are you sure only the C270 is affected?
> > 
> > 	Regards
> > 		Oliver
> 
> Hello Oliver,
> 
> No, unfortunately I am not sure but I am missing the hardware to
> properly test. I am quite sure that it fixes the problem in the C270
> though :)

Well, after all that time neither do I have the test hardware.
And I doubt that for some reason only the C270 should be affected.

> Thanks for that, since you were the author of the first commit.

I appreciate your patch, but I think teh safe option would be to do
it for all models.

	Regards
		Oliver

PS: Are you really in Montenegro or is that just a close address?

Re: [PATCH] Fix chipmunk-like voice when using Logitech C270 for recording audio.

[Greg Kroah-Hartman]

On Tue, Jun 04, 2019 at 11:14:37AM +0200, Oliver Neukum wrote:
> Am Montag, den 03.06.2019, 19:55 +0200 schrieb Marco Zatta:
> > On Mon, Jun 03, 2019 at 11:58:10AM +0200, Oliver Neukum wrote:
> > > Are you sure only the C270 is affected?
> > > 
> > > 	Regards
> > > 		Oliver
> > 
> > Hello Oliver,
> > 
> > No, unfortunately I am not sure but I am missing the hardware to
> > properly test. I am quite sure that it fixes the problem in the C270
> > though :)
> 
> Well, after all that time neither do I have the test hardware.
> And I doubt that for some reason only the C270 should be affected.
> 
> > Thanks for that, since you were the author of the first commit.
> 
> I appreciate your patch, but I think teh safe option would be to do
> it for all models.

As we don't have anyone else complaining at the moment, let's just take
this patch as-for now.

thanks,

greg k-h

Re: [PATCH] Fix chipmunk-like voice when using Logitech C270 for recording audio.

[Aidan Thornton]

On Mon, Jun 3, 2019 at 12:46 PM Oliver Neukum <oneukum@suse.com> wrote:
>
> Am Samstag, den 01.06.2019, 09:52 +0200 schrieb Marco Zatta:
> > This patch fixes the chipmunk-like voice that manifets randomly when
> > using the integrated mic of the Logitech Webcam HD C270.
> >
> > The issue was solved initially for this device by commit
> > 2394d67e446bf616a0885167d5f0d397bdacfdfc but it was then reintroduced by
> > e387ef5c47ddeaeaa3cbdc54424cdb7a28dae2c0. This patch is to have the fix
> > back.
>
> Are you sure only the C270 is affected?

I can unfortunately confirm that it doesn't just seem to be the C270.
I've been having the same problem with my Logitech Webcam Pro 9000
which was one of the models that 2394d67e446b applied the RESET_RESUME
quirk to, and adding it to the quirks list appears to have solved the
problem.

This doesn't make much sense though. e387ef5c47dd should apply this
quirk to all Logitech UVC webcams, and this is definitely a UVC-based
Logitech webcam with the appropriate VID and interface descriptor.
Surely it shouldn't make any difference whether I add an entry for the
specific VID+PID pair of my particular camera or not? The C270 is as
well, I think.

What's particularly annoying is that since this is an intermittent
problem, it's hard to tell if I'm chasing a phantom solution for it
again. Haven't managed to replicate it since applying this fix and did
so pretty quickly before but you never know.

Re: [PATCH] Fix chipmunk-like voice when using Logitech C270 for recording audio.

[Oliver Neukum]

Am Donnerstag, den 20.06.2019, 21:19 +0100 schrieb Aidan Thornton:

> This doesn't make much sense though. e387ef5c47dd should apply this
> quirk to all Logitech UVC webcams, and this is definitely a UVC-based
> Logitech webcam with the appropriate VID and interface descriptor.
> Surely it shouldn't make any difference whether I add an entry for the
> specific VID+PID pair of my particular camera or not? The C270 is as
> well, I think.

Well, it is applied a little later.

> What's particularly annoying is that since this is an intermittent
> problem, it's hard to tell if I'm chasing a phantom solution for it
> again. Haven't managed to replicate it since applying this fix and did
> so pretty quickly before but you never know.

Should I just readd everything removed in e387ef5c47dd?

Greg, what do you think? This is hard to test, the hardware is old
and I want to avoid chasing them all separately.

	Regards
		Oliver

Re: [PATCH] Fix chipmunk-like voice when using Logitech C270 for recording audio.

[Greg Kroah-Hartman]

On Tue, Jul 02, 2019 at 02:46:42PM +0200, Oliver Neukum wrote:
> Am Donnerstag, den 20.06.2019, 21:19 +0100 schrieb Aidan Thornton:
> 
> > This doesn't make much sense though. e387ef5c47dd should apply this
> > quirk to all Logitech UVC webcams, and this is definitely a UVC-based
> > Logitech webcam with the appropriate VID and interface descriptor.
> > Surely it shouldn't make any difference whether I add an entry for the
> > specific VID+PID pair of my particular camera or not? The C270 is as
> > well, I think.
> 
> Well, it is applied a little later.
> 
> > What's particularly annoying is that since this is an intermittent
> > problem, it's hard to tell if I'm chasing a phantom solution for it
> > again. Haven't managed to replicate it since applying this fix and did
> > so pretty quickly before but you never know.
> 
> Should I just readd everything removed in e387ef5c47dd?
> 
> Greg, what do you think? This is hard to test, the hardware is old
> and I want to avoid chasing them all separately.

It's up to you, if you think the issue is resolved if we readd
everything, that's fine with me.

thanks,

greg k-h

Re: [PATCH] Fix chipmunk-like voice when using Logitech C270 for recording audio.

[Oliver Neukum]

[-- Attachment #1: Type: text/plain, Size: 449 bytes --]

Am Donnerstag, den 20.06.2019, 21:19 +0100 schrieb Aidan Thornton:

> What's particularly annoying is that since this is an intermittent
> problem, it's hard to tell if I'm chasing a phantom solution for it
> again. Haven't managed to replicate it since applying this fix and did
> so pretty quickly before but you never know.
> 

This is time for the sledge hammer. No more surgical solutions.
Could you test the attached patch?

	Regards
		Oliver

[-- Attachment #2: 0001-Revert-usb-Add-USB_QUIRK_RESET_RESUME-for-all-Logite.patch --]
[-- Type: text/x-patch, Size: 3849 bytes --]

From 06b826bf3e2d3fb15aee676185c632b9f08a10db Mon Sep 17 00:00:00 2001
From: Oliver Neukum <oneukum@suse.com>
Date: Wed, 3 Jul 2019 15:31:05 +0200
Subject: [PATCH] Revert "usb: Add USB_QUIRK_RESET_RESUME for all Logitech UVC
 webcams"

This s a partial revert of commit e387ef5c47ddeaeaa3cbdc54424cdb7a28dae2c0.
The original fix for the "squeaky voice" bug of some Logitech webcams
when used as audio devices was in

2394d67e446bf616a0885167d5f0d397bdacfdfc ("USB: add RESET_RESUME for
webcams shown to be quirky")

which in subsequent development was undone. Later tests have shown
the consolodiation to be not equivalent.
So I am taking the conservative approach, blacklisting everything that
was blacklisted at any point in the past. We have reports of multiple
devices affected and retesting this on so many old devices is
impractical.

Signed-off-by: Oliver Neukum <oneukum@suse.com>
Reported-by: Aidan Thornton <makosoft@gmail.com>
Reported-by: Marco Zatta <marco@zatta.me>
---
 drivers/usb/core/quirks.c | 53 ++++++++++++++++++++++++++++++++++++++---------
 1 file changed, 43 insertions(+), 10 deletions(-)

diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index 533fe8c0f0a2..e3c24d5b2959 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -234,20 +234,53 @@ static const struct usb_device_id usb_quirk_list[] = {
 	/* Logitech Quickcam Fusion */
 	{ USB_DEVICE(0x046d, 0x08c1), .driver_info = USB_QUIRK_RESET_RESUME },
 
-	/* Logitech Quickcam Orbit MP */
-	{ USB_DEVICE(0x046d, 0x08c2), .driver_info = USB_QUIRK_RESET_RESUME },
+	/* Logitech Webcam C200 */
+	{ USB_DEVICE(0x046d, 0x0802), .driver_info = USB_QUIRK_RESET_RESUME },
 
-	/* Logitech Quickcam Pro for Notebook */
-	{ USB_DEVICE(0x046d, 0x08c3), .driver_info = USB_QUIRK_RESET_RESUME },
+	/* Logitech Webcam C250 */
+	{ USB_DEVICE(0x046d, 0x0804), .driver_info = USB_QUIRK_RESET_RESUME },
 
-	/* Logitech Quickcam Pro 5000 */
-	{ USB_DEVICE(0x046d, 0x08c5), .driver_info = USB_QUIRK_RESET_RESUME },
+	/* Logitech Webcam C300 */
+	{ USB_DEVICE(0x046d, 0x0805), .driver_info = USB_QUIRK_RESET_RESUME },
 
-	/* Logitech Quickcam OEM Dell Notebook */
-	{ USB_DEVICE(0x046d, 0x08c6), .driver_info = USB_QUIRK_RESET_RESUME },
+	/* Logitech Webcam B/C500 */
+	{ USB_DEVICE(0x046d, 0x0807), .driver_info = USB_QUIRK_RESET_RESUME },
 
-	/* Logitech Quickcam OEM Cisco VT Camera II */
-	{ USB_DEVICE(0x046d, 0x08c7), .driver_info = USB_QUIRK_RESET_RESUME },
+	/* Logitech Webcam C600 */
+	{ USB_DEVICE(0x046d, 0x0808), .driver_info = USB_QUIRK_RESET_RESUME },
+
+	/* Logitech Webcam Pro 9000 */
+	{ USB_DEVICE(0x046d, 0x0809), .driver_info = USB_QUIRK_RESET_RESUME },
+
+	/* Logitech Webcam C905 */
+	{ USB_DEVICE(0x046d, 0x080a), .driver_info = USB_QUIRK_RESET_RESUME },
+
+	/* Logitech Webcam C210 */
+	{ USB_DEVICE(0x046d, 0x0819), .driver_info = USB_QUIRK_RESET_RESUME },
+
+	/* Logitech Webcam C260 */
+	{ USB_DEVICE(0x046d, 0x081a), .driver_info = USB_QUIRK_RESET_RESUME },
+
+	/* Logitech Webcam C310 */
+	{ USB_DEVICE(0x046d, 0x081b), .driver_info = USB_QUIRK_RESET_RESUME },
+
+	/* Logitech Webcam C910 */
+	{ USB_DEVICE(0x046d, 0x0821), .driver_info = USB_QUIRK_RESET_RESUME },
+
+	/* Logitech Webcam C160 */
+	{ USB_DEVICE(0x046d, 0x0824), .driver_info = USB_QUIRK_RESET_RESUME },
+
+	/* Logitech Webcam C270 */
+	{ USB_DEVICE(0x046d, 0x0825), .driver_info = USB_QUIRK_RESET_RESUME },
+
+	/* Logitech Quickcam Pro 9000 */
+	{ USB_DEVICE(0x046d, 0x0990), .driver_info = USB_QUIRK_RESET_RESUME },
+
+	/* Logitech Quickcam E3500 */
+	{ USB_DEVICE(0x046d, 0x09a4), .driver_info = USB_QUIRK_RESET_RESUME },
+
+	/* Logitech Quickcam Vision Pro */
+	{ USB_DEVICE(0x046d, 0x09a6), .driver_info = USB_QUIRK_RESET_RESUME },
 
 	/* Logitech Harmony 700-series */
 	{ USB_DEVICE(0x046d, 0xc122), .driver_info = USB_QUIRK_DELAY_INIT },
-- 
2.16.4