From: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Kernel development list <linux-kernel@vger.kernel.org>,
SCSI development list <linux-scsi@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"open list:USB MASS STORAGE DRIVER" <linux-usb@vger.kernel.org>,
"open list:USB MASS STORAGE DRIVER"
<usb-storage@lists.one-eyed-alien.net>
Subject: Re: [PATCH 2/2] usb: storage: scsiglue: Do not skip VPD if try_vpd_pages is set
Date: Tue, 18 Jun 2019 12:17:39 -0300 [thread overview]
Message-ID: <20190618151737.GA16959@geeko> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1906180946160.1659-100000@iolanthe.rowland.org>
On Tue, Jun 18, 2019 at 09:48:01AM -0400, Alan Stern wrote:
> On Mon, 17 Jun 2019, Marcos Paulo de Souza wrote:
>
> > If BLIST_TRY_VPD_PAGES is set for a device, even for an USB, it should
> > be honored, so only set skip_vpd_pages is try_vpd_pages is not set.
> >
> > Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
> > ---
> > drivers/usb/storage/scsiglue.c | 7 +++++--
> > 1 file changed, 5 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/usb/storage/scsiglue.c b/drivers/usb/storage/scsiglue.c
> > index 59190d88fa9f..0a9520780771 100644
> > --- a/drivers/usb/storage/scsiglue.c
> > +++ b/drivers/usb/storage/scsiglue.c
> > @@ -195,8 +195,11 @@ static int slave_configure(struct scsi_device *sdev)
> > */
> > sdev->skip_ms_page_8 = 1;
> >
> > - /* Some devices don't handle VPD pages correctly */
> > - sdev->skip_vpd_pages = 1;
> > + /*
> > + * Some devices don't handle VPD pages correctly, so skip vpd
> > + * pages if not forced by SCSI layer.
> > + */
> > + sdev->skip_vpd_pages = sdev->try_vpd_pages == 0;
> >
> > /* Do not attempt to use REPORT SUPPORTED OPERATION CODES */
> > sdev->no_report_opcodes = 1;
>
> Acked-by: Alan Stern <stern@rowland.harvard.edu>
>
> Although I think it would be clearer to write:
>
> sdev->skip_vpd_pages = !sdev->try_vpd_pages;
I agree. Greg, would you like me to send a v2 of this patch with this change, or
can you apply the change suggested by Alan?
Thanks,
Marcos
>
> But that's just personal preference. This is okay as it is.
>
> Alan Stern
>
--
Thanks,
Marcos
next prev parent reply other threads:[~2019-06-18 15:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190618013146.21961-1-marcos.souza.org@gmail.com>
2019-06-18 1:31 ` [PATCH 2/2] usb: storage: scsiglue: Do not skip VPD if try_vpd_pages is set Marcos Paulo de Souza
2019-06-18 6:49 ` Greg Kroah-Hartman
2019-06-18 10:30 ` Marcos Paulo de Souza
2019-06-18 10:52 ` Greg Kroah-Hartman
2019-06-18 10:56 ` Marcos Paulo de Souza
2019-06-18 13:48 ` Alan Stern
2019-06-18 15:17 ` Marcos Paulo de Souza [this message]
2019-06-18 16:07 ` Greg Kroah-Hartman
2019-06-18 22:46 ` Marcos Paulo de Souza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190618151737.GA16959@geeko \
--to=marcos.souza.org@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=usb-storage@lists.one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).