From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Felipe Balbi <balbi@kernel.org>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Minas Harutyunyan <hminas@synopsys.com>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: remove redundant 'default n' from Kconfig-s
Date: Thu, 20 Jun 2019 14:08:21 +0200 [thread overview]
Message-ID: <20190620120821.GA19295@kroah.com> (raw)
In-Reply-To: <874l4ngxl5.fsf@linux.intel.com>
On Tue, Jun 18, 2019 at 10:29:58AM +0300, Felipe Balbi wrote:
> Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> writes:
>
> > 'default n' is the default value for any bool or tristate Kconfig
> > setting so there is no need to write it explicitly.
> >
> > Also since commit f467c5640c29 ("kconfig: only write '# CONFIG_FOO
> > is not set' for visible symbols") the Kconfig behavior is the same
> > regardless of 'default n' being present or not:
> >
> > ...
> > One side effect of (and the main motivation for) this change is making
> > the following two definitions behave exactly the same:
> >
> > config FOO
> > bool
> >
> > config FOO
> > bool
> > default n
> >
> > With this change, neither of these will generate a
> > '# CONFIG_FOO is not set' line (assuming FOO isn't selected/implied).
> > That might make it clearer to people that a bare 'default n' is
> > redundant.
> > ...
> >
> > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
>
> Fine by me. Greg if you want to take this directly (since it touches
> things all over the place):
>
> Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com>
>
> If you prefer that I put this in my pull request to you, just let me know.
I think I already took this :)
prev parent reply other threads:[~2019-06-20 12:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190520141434eucas1p266520a2ef8db42b3deee004e1cba3a1f@eucas1p2.samsung.com>
2019-05-20 14:14 ` [PATCH] usb: remove redundant 'default n' from Kconfig-s Bartlomiej Zolnierkiewicz
2019-06-18 7:29 ` Felipe Balbi
2019-06-20 12:08 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190620120821.GA19295@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=b.zolnierkie@samsung.com \
--cc=balbi@kernel.org \
--cc=hminas@synopsys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).