Linux-USB Archive on lore.kernel.org
 help / color / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: dmg@turingmachine.org
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: clean up some of the computations in adu_read
Date: Fri, 21 Jun 2019 09:16:55 +0200
Message-ID: <20190621071655.GA20682@kroah.com> (raw)
In-Reply-To: <20190621065921.5199-1-dmg@turingmachine.org>

On Thu, Jun 20, 2019 at 11:59:21PM -0700, dmg@turingmachine.org wrote:
> From: Daniel M German <dmg@turingmachine.org>
> 
> Replace ?: with min to calculate the number of bytes in the secondary buffer,
> including changing the data type of data_in_secondary to size_t to be
> type-consistent. data_in_secondary can never be negative.
> 
> Remove some spurious calculations (copy_to_user returns zero on success),
> making one variable redundant (i)
> 
> This change does not alter the functionality of the code.
> 
> Signed-off-by: Daniel M German <dmg@turingmachine.org>
> ---
>  drivers/usb/misc/adutux.c | 16 +++++++---------
>  1 file changed, 7 insertions(+), 9 deletions(-)

When sending a new version of a patch, you need to version it.  The
documentation says how to do this, but basically you need a "v2" in the
subject line ([PATCH v2]) and then below the --- line, you need to say
what has changed from the previous version.

Can you resend a v3 of this patch that has all of that in it?

thanks,

greg k-h

  reply index

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-21  6:59 dmg
2019-06-21  7:16 ` Greg KH [this message]
2019-06-21 15:22   ` [PATCH v3] " dmg
2019-06-21 15:55     ` dmg
  -- strict thread matches above, loose matches on Subject: below --
2019-06-19 20:16 [PATCH] " dmg

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190621071655.GA20682@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=dmg@turingmachine.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-USB Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-usb/0 linux-usb/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-usb linux-usb/ https://lore.kernel.org/linux-usb \
		linux-usb@vger.kernel.org
	public-inbox-index linux-usb

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-usb


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git