From: Ming Lei <ming.lei@redhat.com>
To: Finn Thain <fthain@telegraphics.com.au>
Cc: Steffen Maier <maier@linux.ibm.com>,
linux-scsi@vger.kernel.org,
"Martin K . Petersen" <martin.petersen@oracle.com>,
James Bottomley <James.Bottomley@hansenpartnership.com>,
Bart Van Assche <bvanassche@acm.org>,
Hannes Reinecke <hare@suse.com>, Christoph Hellwig <hch@lst.de>,
Jim Gill <jgill@vmware.com>, Cathy Avery <cavery@redhat.com>,
"Ewan D . Milne" <emilne@redhat.com>,
Brian King <brking@us.ibm.com>,
James Smart <james.smart@broadcom.com>,
"Juergen E . Fischer" <fischer@norbit.de>,
Michael Schmitz <schmitzmic@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-usb@vger.kernel.org,
Dan Carpenter <dan.carpenter@oracle.com>,
Benjamin Block <bblock@linux.ibm.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
linux-s390@vger.kernel.org
Subject: Re: [PATCH V5 10/16] s390: zfcp_fc: use sg helper to operate scatterlist
Date: Tue, 25 Jun 2019 10:30:28 +0800
Message-ID: <20190625023027.GF23777@ming.t460p> (raw)
In-Reply-To: <alpine.LNX.2.21.1906251157160.8@nippy.intranet>
On Tue, Jun 25, 2019 at 12:01:24PM +1000, Finn Thain wrote:
> > diff --git a/drivers/s390/scsi/zfcp_dbf.c b/drivers/s390/scsi/zfcp_dbf.c
> > index dccdb41bed8c..c7129f5234f0 100644
> > --- a/drivers/s390/scsi/zfcp_dbf.c
> > +++ b/drivers/s390/scsi/zfcp_dbf.c
> > @@ -552,7 +552,7 @@ static u16 zfcp_dbf_san_res_cap_len_if_gpn_ft(char *tag,
> > if (x % (ZFCP_FC_GPN_FT_ENT_PAGE + 1))
> > acc++;
> > else
> > - acc = sg_virt(++resp_entry);
> > + acc = sg_virt(resp_entry = sg_next(resp_entry));
>
> Shouldn't that be,
>
> acc = sg_virt(sg_next(resp_entry));
resp_entry needs to be updated.
>
> >
> > last = acc->fp_flags & FC_NS_FID_LAST;
> > }
> > diff --git a/drivers/s390/scsi/zfcp_fc.c b/drivers/s390/scsi/zfcp_fc.c
> > index b018b61bd168..5048812ce660 100644
> > --- a/drivers/s390/scsi/zfcp_fc.c
> > +++ b/drivers/s390/scsi/zfcp_fc.c
> > @@ -742,7 +742,7 @@ static int zfcp_fc_eval_gpn_ft(struct zfcp_fc_req *fc_req,
> > if (x % (ZFCP_FC_GPN_FT_ENT_PAGE + 1))
> > acc++;
> > else
> > - acc = sg_virt(++sg);
> > + acc = sg_virt(sg = sg_next(sg));
>
> and
>
> acc = sg_virt(sg_next(sg));
>
> ?
Same with above.
Thanks,
Ming
next prev parent reply index
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 1:37 [PATCH V5 00/16] " Ming Lei
2019-06-18 1:37 ` [PATCH V5 01/16] scsi: vmw_pscsi: " Ming Lei
2019-06-18 1:37 ` [PATCH V5 02/16] scsi: advansys: " Ming Lei
2019-06-18 1:37 ` [PATCH V5 03/16] scsi: lpfc: " Ming Lei
2019-06-18 1:37 ` [PATCH V5 04/16] scsi: mvumi: " Ming Lei
2019-06-18 1:37 ` [PATCH V5 05/16] scsi: ipr: " Ming Lei
2019-06-18 1:37 ` [PATCH V5 06/16] scsi: pmcraid: " Ming Lei
2019-06-18 1:37 ` [PATCH V5 07/16] usb: image: microtek: " Ming Lei
2019-06-18 1:37 ` [PATCH V5 08/16] staging: unisys: visorhba: " Ming Lei
2019-06-18 1:37 ` [PATCH V5 09/16] staging: rtsx: " Ming Lei
2019-06-18 1:37 ` [PATCH V5 10/16] s390: zfcp_fc: " Ming Lei
2019-06-24 15:13 ` Steffen Maier
2019-06-25 1:19 ` Ming Lei
2019-06-25 2:01 ` Finn Thain
2019-06-25 2:30 ` Ming Lei [this message]
2019-06-25 3:42 ` Finn Thain
2019-06-25 10:51 ` Steffen Maier
2019-06-26 3:07 ` Ming Lei
2019-06-26 8:17 ` Steffen Maier
2019-06-18 1:37 ` [PATCH V5 11/16] scsi: aha152x: " Ming Lei
2019-06-18 3:54 ` Finn Thain
2019-06-18 1:37 ` [PATCH V5 12/16] scsi: imm: " Ming Lei
2019-06-18 1:37 ` [PATCH V5 13/16] scsi: pcmcia: nsp_cs: " Ming Lei
2019-06-18 1:37 ` [PATCH V5 14/16] scsi: ppa: " Ming Lei
2019-06-18 1:37 ` [PATCH V5 15/16] scsi: wd33c93: " Ming Lei
2019-06-18 1:37 ` [PATCH V5 16/16] NCR5380: Support chained sg lists Ming Lei
2019-06-19 0:29 ` [PATCH V5 00/16] use sg helper to operate scatterlist Martin K. Petersen
2019-06-19 19:43 ` Bart Van Assche
2019-06-19 19:55 ` Martin K. Petersen
2019-06-24 12:40 ` Ming Lei
2019-06-24 12:54 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190625023027.GF23777@ming.t460p \
--to=ming.lei@redhat.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=bblock@linux.ibm.com \
--cc=brking@us.ibm.com \
--cc=bvanassche@acm.org \
--cc=cavery@redhat.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=emilne@redhat.com \
--cc=fischer@norbit.de \
--cc=fthain@telegraphics.com.au \
--cc=gregkh@linuxfoundation.org \
--cc=hare@suse.com \
--cc=hch@lst.de \
--cc=heiko.carstens@de.ibm.com \
--cc=james.smart@broadcom.com \
--cc=jgill@vmware.com \
--cc=linux-s390@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=maier@linux.ibm.com \
--cc=martin.petersen@oracle.com \
--cc=schmitzmic@gmail.com \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Linux-USB Archive on lore.kernel.org
Archives are clonable:
git clone --mirror https://lore.kernel.org/linux-usb/0 linux-usb/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 linux-usb linux-usb/ https://lore.kernel.org/linux-usb \
linux-usb@vger.kernel.org
public-inbox-index linux-usb
Example config snippet for mirrors
Newsgroup available over NNTP:
nntp://nntp.lore.kernel.org/org.kernel.vger.linux-usb
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git