From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Shawn Guo <shawnguo@kernel.org>, Peter Chen <Peter.Chen@nxp.com>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
devicetree@vger.kernel.org, linux-usb@vger.kernel.org
Subject: [PATCH] ARM: imx25: provide a fixed regulator for usb phys
Date: Tue, 25 Jun 2019 12:04:12 +0200 [thread overview]
Message-ID: <20190625100412.11815-1-u.kleine-koenig@pengutronix.de> (raw)
The usb phys are internal to the SoC and so it their 5V supply. With
this regulator added explicitly the following (harmless) boot messages
go away:
usb_phy_generic usbphy:usb-phy@0: usbphy:usb-phy@0 supply vcc not found, using dummy regulator
usb_phy_generic usbphy:usb-phy@1: usbphy:usb-phy@1 supply vcc not found, using dummy regulator
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
Hello,
note I'm an USB noob, so please consider carefully before applying :-)
I also put the regulator near the usbphy node instead of in alphabetic
order. Not sure what is sensible/usual here, too.
Best regards
Uwe
arch/arm/boot/dts/imx25.dtsi | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi
--- a/arch/arm/boot/dts/imx25.dtsi
+++ b/arch/arm/boot/dts/imx25.dtsi
@@ -614,6 +614,11 @@
};
};
+ reg_usb: regulator_usbphy {
+ compatible = "regulator-fixed";
+ regulator-name = "usb-phy supply";
+ };
+
usbphy {
compatible = "simple-bus";
#address-cells = <1>;
@@ -623,12 +630,14 @@
reg = <0>;
compatible = "usb-nop-xceiv";
#phy-cells = <0>;
+ vcc-supply = <®_usb>;
};
usbphy1: usb-phy@1 {
reg = <1>;
compatible = "usb-nop-xceiv";
#phy-cells = <0>;
+ vcc-supply = <®_usb>;
};
};
};
--
2.20.1
next reply other threads:[~2019-06-25 10:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 10:04 Uwe Kleine-König [this message]
2019-06-25 10:44 ` [PATCH] ARM: imx25: provide a fixed regulator for usb phys Sergei Shtylyov
2019-06-26 2:40 ` Peter Chen
2019-06-26 5:54 ` Marco Felsch
2019-06-27 3:15 ` Peter Chen
2019-07-24 13:09 ` Uwe Kleine-König
2019-09-23 10:28 ` Uwe Kleine-König
2019-11-15 9:07 ` Uwe Kleine-König
2021-10-21 11:02 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190625100412.11815-1-u.kleine-koenig@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=Peter.Chen@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-imx@nxp.com \
--cc=linux-usb@vger.kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).