From: Greg KH <gregkh@linuxfoundation.org>
To: Pawel Laszczak <pawell@cadence.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"felipe.balbi@linux.intel.com" <felipe.balbi@linux.intel.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"hdegoede@redhat.com" <hdegoede@redhat.com>,
"heikki.krogerus@linux.intel.com"
<heikki.krogerus@linux.intel.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"rogerq@ti.com" <rogerq@ti.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"jbergsagel@ti.com" <jbergsagel@ti.com>,
"nsekhar@ti.com" <nsekhar@ti.com>, "nm@ti.com" <nm@ti.com>,
Suresh Punnoose <sureshp@cadence.com>,
"peter.chen@nxp.com" <peter.chen@nxp.com>,
Jayshri Dajiram Pawar <jpawar@cadence.com>,
Rahul Kumar <kurahul@cadence.com>
Subject: Re: [PATCH v9 2/6] usb:gadget Separated decoding functions from dwc3 driver.
Date: Fri, 5 Jul 2019 13:49:11 +0200 [thread overview]
Message-ID: <20190705114911.GA31190@kroah.com> (raw)
In-Reply-To: <BYAPR07MB4709AAF54E7C58B51FC26D20DDF50@BYAPR07MB4709.namprd07.prod.outlook.com>
On Fri, Jul 05, 2019 at 11:39:57AM +0000, Pawel Laszczak wrote:
>
> >On Fri, Jul 05, 2019 at 11:57:14AM +0100, Pawel Laszczak wrote:
> >> Patch moves some decoding functions from driver/usb/dwc3/debug.h driver
> >> to driver/usb/gadget/debug.c file. These moved functions include:
> >> dwc3_decode_get_status
> >> dwc3_decode_set_clear_feature
> >> dwc3_decode_set_address
> >> dwc3_decode_get_set_descriptor
> >> dwc3_decode_get_configuration
> >> dwc3_decode_set_configuration
> >> dwc3_decode_get_intf
> >> dwc3_decode_set_intf
> >> dwc3_decode_synch_frame
> >> dwc3_decode_set_sel
> >> dwc3_decode_set_isoch_delay
> >> dwc3_decode_ctrl
> >>
> >> These functions are used also in inroduced cdns3 driver.
> >>
> >> All functions prefixes were changed from dwc3 to usb.
> >> Also, function's parameters has been extended according to the name
> >> of fields in standard SETUP packet.
> >> Additionally, patch adds usb_decode_ctrl function to
> >> include/linux/usb/gadget.h file.
> >
> >No it does not :(
>
> I've forgot about this :(
>
> It should be include/linux/usb/ch.9.h
>
> >
> >> Signed-off-by: Pawel Laszczak <pawell@cadence.com>
> >> ---
> >> drivers/usb/common/Makefile | 5 +
> >> drivers/usb/common/debug.c | 268 ++++++++++++++++++++++++++++++++++++
> >> drivers/usb/dwc3/debug.h | 252 ---------------------------------
> >> drivers/usb/dwc3/trace.h | 2 +-
> >> include/linux/usb/ch9.h | 25 ++++
> >> 5 files changed, 299 insertions(+), 253 deletions(-)
> >> create mode 100644 drivers/usb/common/debug.c
> >>
> >> diff --git a/drivers/usb/common/Makefile b/drivers/usb/common/Makefile
> >> index 0a7c45e85481..cdc66b59a6f0 100644
> >> --- a/drivers/usb/common/Makefile
> >> +++ b/drivers/usb/common/Makefile
> >> @@ -5,6 +5,11 @@
> >>
> >> obj-$(CONFIG_USB_COMMON) += usb-common.o
> >> usb-common-y += common.o
> >> +
> >> +ifneq ($(CONFIG_TRACING),)
> >> + usb-common-y += debug.o
> >> +endif
> >
> >So only enable this if tracing is not emabled? Or if enabled? I'm
> >confused, isn't there an easier way to write this?
>
> It's checks if CONFIG_TRACING is enable.
> It's a common way checking if option is enabled in usb subsystem.
Why not just write this as:
usb-common-$(CONFIG_TRACING) += debug.o
?
thanks,
greg k-h
next prev parent reply other threads:[~2019-07-05 11:49 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-05 10:57 [PATCH v9 0/6] Introduced new Cadence USBSS DRD Driver Pawel Laszczak
2019-07-05 10:57 ` [PATCH v9 1/6] dt-bindings: add binding for USBSS-DRD controller Pawel Laszczak
2019-07-05 10:57 ` [PATCH v9 2/6] usb:gadget Separated decoding functions from dwc3 driver Pawel Laszczak
2019-07-05 11:27 ` Greg KH
2019-07-05 11:39 ` Pawel Laszczak
2019-07-05 11:49 ` Greg KH [this message]
2019-07-05 12:03 ` Pawel Laszczak
2019-07-05 11:39 ` Felipe Balbi
2019-07-05 11:44 ` Pawel Laszczak
2019-08-07 10:17 ` Roger Quadros
2019-08-07 10:22 ` Felipe Balbi
2019-08-08 3:07 ` Pawel Laszczak
2019-07-05 10:57 ` [PATCH v9 3/6] usb:gadget Patch simplify usb_decode_set_clear_feature function Pawel Laszczak
2019-07-05 10:57 ` [PATCH v9 4/6] usb:gadget Simplify usb_decode_get_set_descriptor function Pawel Laszczak
2019-07-05 10:57 ` [PATCH v9 5/6] usb:cdns3 Add Cadence USB3 DRD Driver Pawel Laszczak
2019-07-05 11:55 ` Felipe Balbi
2019-07-07 17:56 ` Pawel Laszczak
2019-07-08 6:29 ` Felipe Balbi
2019-07-08 10:59 ` Pawel Laszczak
2019-07-08 11:15 ` Felipe Balbi
2019-07-08 11:45 ` Pawel Laszczak
2019-07-08 11:59 ` Felipe Balbi
2019-07-08 12:39 ` Pawel Laszczak
2019-07-09 4:23 ` Pawel Laszczak
2019-07-09 6:36 ` Felipe Balbi
2019-07-09 7:07 ` Pawel Laszczak
2019-07-09 7:22 ` Felipe Balbi
2019-07-09 7:29 ` Pawel Laszczak
2019-07-10 8:25 ` Pawel Laszczak
2019-07-08 7:11 ` Felipe Balbi
2019-07-15 11:00 ` Pawel Laszczak
2019-08-07 10:34 ` Felipe Balbi
2019-08-10 20:39 ` Pawel Laszczak
2019-08-12 1:55 ` Peter Chen
2019-08-12 4:43 ` Pawel Laszczak
2019-08-12 5:24 ` Felipe Balbi
2019-08-12 7:13 ` Pawel Laszczak
2019-08-12 8:19 ` Felipe Balbi
2019-08-12 9:13 ` Pawel Laszczak
2019-08-12 9:45 ` Felipe Balbi
2019-08-12 10:26 ` Pawel Laszczak
2019-08-12 10:34 ` Felipe Balbi
2019-08-12 14:20 ` Alan Stern
2019-07-05 10:57 ` [PATCH v9 6/6] usb:cdns3 Fix for stuck packets in on-chip OUT buffer Pawel Laszczak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190705114911.GA31190@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devicetree@vger.kernel.org \
--cc=felipe.balbi@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=jbergsagel@ti.com \
--cc=jpawar@cadence.com \
--cc=kurahul@cadence.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nm@ti.com \
--cc=nsekhar@ti.com \
--cc=pawell@cadence.com \
--cc=peter.chen@nxp.com \
--cc=robh+dt@kernel.org \
--cc=rogerq@ti.com \
--cc=sureshp@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).