From: gavinli@thegavinli.com
To: gregkh@linuxfoundation.o, linux-usb@vger.kernel.org
Cc: Gavin Li <git@thegavinli.com>
Subject: [PATCH] usb: devio: fix mmap() on non-coherent DMA architectures
Date: Thu, 1 Aug 2019 15:01:34 -0700 [thread overview]
Message-ID: <20190801220134.3295-1-gavinli@thegavinli.com> (raw)
From: Gavin Li <git@thegavinli.com>
On architectures that are not (or are optionally) DMA coherent,
dma_alloc_coherent() returns an address into the vmalloc space,
and calling virt_to_phys() on this address returns an unusable
physical address.
This patch replaces the raw remap_pfn_range() call with a call to
dmap_mmap_coherent(), which takes care of the differences between
coherent and non-coherent code paths.
Tested on an arm64 rk3399 board.
Signed-off-by: Gavin Li <git@thegavinli.com>
---
drivers/usb/core/devio.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c
index a02448105527..76ec9aef3eff 100644
--- a/drivers/usb/core/devio.c
+++ b/drivers/usb/core/devio.c
@@ -241,11 +241,10 @@ static int usbdev_mmap(struct file *file, struct vm_area_struct *vma)
usbm->vma_use_count = 1;
INIT_LIST_HEAD(&usbm->memlist);
- if (remap_pfn_range(vma, vma->vm_start,
- virt_to_phys(usbm->mem) >> PAGE_SHIFT,
- size, vma->vm_page_prot) < 0) {
+ ret = dma_mmap_coherent(ps->dev->bus->sysdev, vma, mem, dma_handle, size);
+ if (ret) {
dec_usb_memory_use_count(usbm, &usbm->vma_use_count);
- return -EAGAIN;
+ return ret;
}
vma->vm_flags |= VM_IO;
--
2.22.0
next reply other threads:[~2019-08-01 22:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-01 22:01 gavinli [this message]
2019-08-05 11:37 ` [PATCH] usb: devio: fix mmap() on non-coherent DMA architectures David Laight
2019-08-05 18:33 ` Gavin Li
2019-08-01 22:04 gavinli
2019-08-02 12:14 ` Greg KH
2019-08-02 17:57 ` Gavin Li
2019-08-05 15:17 ` Greg KH
2019-09-04 7:05 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190801220134.3295-1-gavinli@thegavinli.com \
--to=gavinli@thegavinli.com \
--cc=git@thegavinli.com \
--cc=gregkh@linuxfoundation.o \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).