* [PATCH 0/2] Add the BroadMobi BM818 card @ 2019-07-24 14:52 Angus Ainslie (Purism) 2019-07-24 14:52 ` [PATCH 1/2] usb: serial: option: " Angus Ainslie (Purism) 2019-07-24 14:52 ` [PATCH 2/2] net: usb: qmi_wwan: " Angus Ainslie (Purism) 0 siblings, 2 replies; 9+ messages in thread From: Angus Ainslie (Purism) @ 2019-07-24 14:52 UTC (permalink / raw) To: kernel Cc: Bjørn Mork, David S. Miller, Johan Hovold, Greg Kroah-Hartman, netdev, linux-usb, linux-kernel, Angus Ainslie (Purism) Add qmi_wwan and option support for the BroadMobi BM818 Bob Ham (2): usb: serial: option: Add the BroadMobi BM818 card net: usb: qmi_wwan: Add the BroadMobi BM818 card drivers/net/usb/qmi_wwan.c | 1 + drivers/usb/serial/option.c | 2 ++ 2 files changed, 3 insertions(+) -- 2.17.1 ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/2] usb: serial: option: Add the BroadMobi BM818 card 2019-07-24 14:52 [PATCH 0/2] Add the BroadMobi BM818 card Angus Ainslie (Purism) @ 2019-07-24 14:52 ` Angus Ainslie (Purism) 2019-08-05 11:47 ` Johan Hovold 2019-07-24 14:52 ` [PATCH 2/2] net: usb: qmi_wwan: " Angus Ainslie (Purism) 1 sibling, 1 reply; 9+ messages in thread From: Angus Ainslie (Purism) @ 2019-07-24 14:52 UTC (permalink / raw) To: kernel Cc: Bjørn Mork, David S. Miller, Johan Hovold, Greg Kroah-Hartman, netdev, linux-usb, linux-kernel, Bob Ham, Angus Ainslie From: Bob Ham <bob.ham@puri.sm> Add a VID:PID for the BroadModi BM818 M.2 card Signed-off-by: Bob Ham <bob.ham@puri.sm> Signed-off-by: Angus Ainslie (Purism) <angus@akkea.ca> --- drivers/usb/serial/option.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c index c1582fbd1150..674a68ee9564 100644 --- a/drivers/usb/serial/option.c +++ b/drivers/usb/serial/option.c @@ -1975,6 +1975,8 @@ static const struct usb_device_id option_ids[] = { .driver_info = RSVD(4) | RSVD(5) }, { USB_DEVICE_INTERFACE_CLASS(0x2cb7, 0x0105, 0xff), /* Fibocom NL678 series */ .driver_info = RSVD(6) }, + { USB_DEVICE(0x2020, 0x2060), /* BroadMobi */ + .driver_info = RSVD(4) }, { } /* Terminating entry */ }; MODULE_DEVICE_TABLE(usb, option_ids); -- 2.17.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] usb: serial: option: Add the BroadMobi BM818 card 2019-07-24 14:52 ` [PATCH 1/2] usb: serial: option: " Angus Ainslie (Purism) @ 2019-08-05 11:47 ` Johan Hovold 2019-08-05 14:44 ` Bob Ham 0 siblings, 1 reply; 9+ messages in thread From: Johan Hovold @ 2019-08-05 11:47 UTC (permalink / raw) To: Angus Ainslie (Purism) Cc: kernel, Bjørn Mork, David S. Miller, Johan Hovold, Greg Kroah-Hartman, netdev, linux-usb, linux-kernel, Bob Ham On Wed, Jul 24, 2019 at 07:52:26AM -0700, Angus Ainslie (Purism) wrote: > From: Bob Ham <bob.ham@puri.sm> > > Add a VID:PID for the BroadModi BM818 M.2 card Would you mind posting the output of usb-devices (or lsusb -v) for this device? > Signed-off-by: Bob Ham <bob.ham@puri.sm> > Signed-off-by: Angus Ainslie (Purism) <angus@akkea.ca> > --- > drivers/usb/serial/option.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c > index c1582fbd1150..674a68ee9564 100644 > --- a/drivers/usb/serial/option.c > +++ b/drivers/usb/serial/option.c > @@ -1975,6 +1975,8 @@ static const struct usb_device_id option_ids[] = { > .driver_info = RSVD(4) | RSVD(5) }, > { USB_DEVICE_INTERFACE_CLASS(0x2cb7, 0x0105, 0xff), /* Fibocom NL678 series */ > .driver_info = RSVD(6) }, > + { USB_DEVICE(0x2020, 0x2060), /* BroadMobi */ Looks like you forgot to include the model in the comment here. And please move this one after the other 0x2020 (PID 0x2031) entry. Should you also be using USB_DEVICE_INTERFACE_CLASS() (e.g. to avoid matching a mass-storage interface)? > + .driver_info = RSVD(4) }, > { } /* Terminating entry */ > }; > MODULE_DEVICE_TABLE(usb, option_ids); Johan ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] usb: serial: option: Add the BroadMobi BM818 card 2019-08-05 11:47 ` Johan Hovold @ 2019-08-05 14:44 ` Bob Ham 2019-08-15 11:49 ` Johan Hovold 0 siblings, 1 reply; 9+ messages in thread From: Bob Ham @ 2019-08-05 14:44 UTC (permalink / raw) To: Johan Hovold, Angus Ainslie (Purism) Cc: kernel, Bjørn Mork, David S. Miller, Greg Kroah-Hartman, netdev, linux-usb, linux-kernel [-- Attachment #1.1: Type: text/plain, Size: 950 bytes --] On 05/08/2019 12:47, Johan Hovold wrote: > On Wed, Jul 24, 2019 at 07:52:26AM -0700, Angus Ainslie (Purism) wrote: >> From: Bob Ham <bob.ham@puri.sm> >> >> Add a VID:PID for the BroadModi BM818 M.2 card > > Would you mind posting the output of usb-devices (or lsusb -v) for this > device? T: Bus=01 Lev=03 Prnt=40 Port=03 Cnt=01 Dev#= 44 Spd=480 MxCh= 0 D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1 P: Vendor=2020 ProdID=2060 Rev=00.00 S: Manufacturer=Qualcomm, Incorporated S: Product=Qualcomm CDMA Technologies MSM C: #Ifs= 5 Cfg#= 1 Atr=e0 MxPwr=500mA I: If#=0x0 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none) I: If#=0x1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none) I: If#=0x2 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none) I: If#=0x3 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=fe Prot=ff Driver=(none) I: If#=0x4 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none) [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] usb: serial: option: Add the BroadMobi BM818 card 2019-08-05 14:44 ` Bob Ham @ 2019-08-15 11:49 ` Johan Hovold 2019-08-15 12:19 ` Bob Ham 0 siblings, 1 reply; 9+ messages in thread From: Johan Hovold @ 2019-08-15 11:49 UTC (permalink / raw) To: Bob Ham Cc: Johan Hovold, Angus Ainslie (Purism), kernel, Bjørn Mork, David S. Miller, Greg Kroah-Hartman, netdev, linux-usb, linux-kernel [-- Attachment #1: Type: text/plain, Size: 1230 bytes --] On Mon, Aug 05, 2019 at 03:44:30PM +0100, Bob Ham wrote: > On 05/08/2019 12:47, Johan Hovold wrote: > > On Wed, Jul 24, 2019 at 07:52:26AM -0700, Angus Ainslie (Purism) wrote: > >> From: Bob Ham <bob.ham@puri.sm> > >> > >> Add a VID:PID for the BroadModi BM818 M.2 card > > > > Would you mind posting the output of usb-devices (or lsusb -v) for this > > device? > > T: Bus=01 Lev=03 Prnt=40 Port=03 Cnt=01 Dev#= 44 Spd=480 MxCh= 0 > D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1 > P: Vendor=2020 ProdID=2060 Rev=00.00 > S: Manufacturer=Qualcomm, Incorporated > S: Product=Qualcomm CDMA Technologies MSM > C: #Ifs= 5 Cfg#= 1 Atr=e0 MxPwr=500mA > I: If#=0x0 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none) > I: If#=0x1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none) > I: If#=0x2 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none) > I: If#=0x3 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=fe Prot=ff Driver=(none) > I: If#=0x4 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none) I amended the commit message with the above, switched to USB_DEVICE_INTERFACE_CLASS(), fixed the comment and moved the entry to the other 0x2020 entries before applying. Johan [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] usb: serial: option: Add the BroadMobi BM818 card 2019-08-15 11:49 ` Johan Hovold @ 2019-08-15 12:19 ` Bob Ham 2019-08-15 12:28 ` Johan Hovold 0 siblings, 1 reply; 9+ messages in thread From: Bob Ham @ 2019-08-15 12:19 UTC (permalink / raw) To: Johan Hovold Cc: Angus Ainslie (Purism), kernel, Bjørn Mork, David S. Miller, Greg Kroah-Hartman, netdev, linux-usb, linux-kernel [-- Attachment #1.1: Type: text/plain, Size: 1441 bytes --] On 15/08/2019 12:49, Johan Hovold wrote: > On Mon, Aug 05, 2019 at 03:44:30PM +0100, Bob Ham wrote: >> On 05/08/2019 12:47, Johan Hovold wrote: >>> On Wed, Jul 24, 2019 at 07:52:26AM -0700, Angus Ainslie (Purism) wrote: >>>> From: Bob Ham <bob.ham@puri.sm> >>>> >>>> Add a VID:PID for the BroadModi BM818 M.2 card >>> >>> Would you mind posting the output of usb-devices (or lsusb -v) for this >>> device? >> >> T: Bus=01 Lev=03 Prnt=40 Port=03 Cnt=01 Dev#= 44 Spd=480 MxCh= 0 >> D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1 >> P: Vendor=2020 ProdID=2060 Rev=00.00 >> S: Manufacturer=Qualcomm, Incorporated >> S: Product=Qualcomm CDMA Technologies MSM >> C: #Ifs= 5 Cfg#= 1 Atr=e0 MxPwr=500mA >> I: If#=0x0 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none) >> I: If#=0x1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none) >> I: If#=0x2 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none) >> I: If#=0x3 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=fe Prot=ff Driver=(none) >> I: If#=0x4 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none) > > I amended the commit message with the above, switched to > USB_DEVICE_INTERFACE_CLASS(), fixed the comment and moved the entry > to the other 0x2020 entries before applying. Sorry I should probably have mentioned this before but Angus has been on vacation, hence the silence on the other matters. Regardless, thanks. Bob [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] usb: serial: option: Add the BroadMobi BM818 card 2019-08-15 12:19 ` Bob Ham @ 2019-08-15 12:28 ` Johan Hovold 0 siblings, 0 replies; 9+ messages in thread From: Johan Hovold @ 2019-08-15 12:28 UTC (permalink / raw) To: Bob Ham Cc: Johan Hovold, Angus Ainslie (Purism), kernel, Bjørn Mork, David S. Miller, Greg Kroah-Hartman, netdev, linux-usb, linux-kernel [-- Attachment #1: Type: text/plain, Size: 1576 bytes --] On Thu, Aug 15, 2019 at 01:19:19PM +0100, Bob Ham wrote: > On 15/08/2019 12:49, Johan Hovold wrote: > > On Mon, Aug 05, 2019 at 03:44:30PM +0100, Bob Ham wrote: > >> On 05/08/2019 12:47, Johan Hovold wrote: > >>> On Wed, Jul 24, 2019 at 07:52:26AM -0700, Angus Ainslie (Purism) wrote: > >>>> From: Bob Ham <bob.ham@puri.sm> > >>>> > >>>> Add a VID:PID for the BroadModi BM818 M.2 card > >>> > >>> Would you mind posting the output of usb-devices (or lsusb -v) for this > >>> device? > >> > >> T: Bus=01 Lev=03 Prnt=40 Port=03 Cnt=01 Dev#= 44 Spd=480 MxCh= 0 > >> D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1 > >> P: Vendor=2020 ProdID=2060 Rev=00.00 > >> S: Manufacturer=Qualcomm, Incorporated > >> S: Product=Qualcomm CDMA Technologies MSM > >> C: #Ifs= 5 Cfg#= 1 Atr=e0 MxPwr=500mA > >> I: If#=0x0 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none) > >> I: If#=0x1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none) > >> I: If#=0x2 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none) > >> I: If#=0x3 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=fe Prot=ff Driver=(none) > >> I: If#=0x4 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none) > > > > I amended the commit message with the above, switched to > > USB_DEVICE_INTERFACE_CLASS(), fixed the comment and moved the entry > > to the other 0x2020 entries before applying. > > Sorry I should probably have mentioned this before but Angus has been on > vacation, hence the silence on the other matters. Regardless, thanks. Ok, no worries. Johan [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 2/2] net: usb: qmi_wwan: Add the BroadMobi BM818 card 2019-07-24 14:52 [PATCH 0/2] Add the BroadMobi BM818 card Angus Ainslie (Purism) 2019-07-24 14:52 ` [PATCH 1/2] usb: serial: option: " Angus Ainslie (Purism) @ 2019-07-24 14:52 ` Angus Ainslie (Purism) 2019-07-26 21:00 ` David Miller 1 sibling, 1 reply; 9+ messages in thread From: Angus Ainslie (Purism) @ 2019-07-24 14:52 UTC (permalink / raw) To: kernel Cc: Bjørn Mork, David S. Miller, Johan Hovold, Greg Kroah-Hartman, netdev, linux-usb, linux-kernel, Bob Ham, Angus Ainslie From: Bob Ham <bob.ham@puri.sm> The BroadMobi BM818 M.2 card uses the QMI protocol Signed-off-by: Bob Ham <bob.ham@puri.sm> Signed-off-by: Angus Ainslie (Purism) <angus@akkea.ca> --- drivers/net/usb/qmi_wwan.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c index 69e0a2acfcb0..b6dc5d714b5e 100644 --- a/drivers/net/usb/qmi_wwan.c +++ b/drivers/net/usb/qmi_wwan.c @@ -1295,6 +1295,7 @@ static const struct usb_device_id products[] = { {QMI_FIXED_INTF(0x2001, 0x7e3d, 4)}, /* D-Link DWM-222 A2 */ {QMI_FIXED_INTF(0x2020, 0x2031, 4)}, /* Olicard 600 */ {QMI_FIXED_INTF(0x2020, 0x2033, 4)}, /* BroadMobi BM806U */ + {QMI_FIXED_INTF(0x2020, 0x2060, 4)}, /* BroadMobi BM818 */ {QMI_FIXED_INTF(0x0f3d, 0x68a2, 8)}, /* Sierra Wireless MC7700 */ {QMI_FIXED_INTF(0x114f, 0x68a2, 8)}, /* Sierra Wireless MC7750 */ {QMI_FIXED_INTF(0x1199, 0x68a2, 8)}, /* Sierra Wireless MC7710 in QMI mode */ -- 2.17.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] net: usb: qmi_wwan: Add the BroadMobi BM818 card 2019-07-24 14:52 ` [PATCH 2/2] net: usb: qmi_wwan: " Angus Ainslie (Purism) @ 2019-07-26 21:00 ` David Miller 0 siblings, 0 replies; 9+ messages in thread From: David Miller @ 2019-07-26 21:00 UTC (permalink / raw) To: angus Cc: kernel, bjorn, johan, gregkh, netdev, linux-usb, linux-kernel, bob.ham From: "Angus Ainslie (Purism)" <angus@akkea.ca> Date: Wed, 24 Jul 2019 07:52:27 -0700 > From: Bob Ham <bob.ham@puri.sm> > > The BroadMobi BM818 M.2 card uses the QMI protocol > > Signed-off-by: Bob Ham <bob.ham@puri.sm> > Signed-off-by: Angus Ainslie (Purism) <angus@akkea.ca> Applied, thanks. ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2019-08-15 12:28 UTC | newest] Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-07-24 14:52 [PATCH 0/2] Add the BroadMobi BM818 card Angus Ainslie (Purism) 2019-07-24 14:52 ` [PATCH 1/2] usb: serial: option: " Angus Ainslie (Purism) 2019-08-05 11:47 ` Johan Hovold 2019-08-05 14:44 ` Bob Ham 2019-08-15 11:49 ` Johan Hovold 2019-08-15 12:19 ` Bob Ham 2019-08-15 12:28 ` Johan Hovold 2019-07-24 14:52 ` [PATCH 2/2] net: usb: qmi_wwan: " Angus Ainslie (Purism) 2019-07-26 21:00 ` David Miller
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).