Linux-USB Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] usb: gadget: atmel_usba_udc: Mark expected switch fall-through
@ 2019-08-05 18:48 Gustavo A. R. Silva
  2019-08-12 14:58 ` Alexandre Belloni
  2019-08-16 10:27 ` Cristian.Birsan
  0 siblings, 2 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2019-08-05 18:48 UTC (permalink / raw)
  To: Cristian Birsan, Felipe Balbi, Greg Kroah-Hartman, Nicolas Ferre,
	Alexandre Belloni, Ludovic Desroches
  Cc: linux-arm-kernel, linux-usb, linux-kernel, Gustavo A. R. Silva

Mark switch cases where we are expecting to fall through.

This patch fixes the following warning (Building: at91_dt_defconfig arm):

drivers/usb/gadget/udc/atmel_usba_udc.c:329:13: warning: this statement may fall through [-Wimplicit-fallthrough=]

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
 drivers/usb/gadget/udc/atmel_usba_udc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c
index 503d275bc4c4..86ffc8307864 100644
--- a/drivers/usb/gadget/udc/atmel_usba_udc.c
+++ b/drivers/usb/gadget/udc/atmel_usba_udc.c
@@ -327,6 +327,7 @@ static int usba_config_fifo_table(struct usba_udc *udc)
 	switch (fifo_mode) {
 	default:
 		fifo_mode = 0;
+		/* fall through */
 	case 0:
 		udc->fifo_cfg = NULL;
 		n = 0;
-- 
2.22.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] usb: gadget: atmel_usba_udc: Mark expected switch fall-through
  2019-08-05 18:48 [PATCH] usb: gadget: atmel_usba_udc: Mark expected switch fall-through Gustavo A. R. Silva
@ 2019-08-12 14:58 ` Alexandre Belloni
  2019-08-16 10:27 ` Cristian.Birsan
  1 sibling, 0 replies; 3+ messages in thread
From: Alexandre Belloni @ 2019-08-12 14:58 UTC (permalink / raw)
  To: Gustavo A. R. Silva
  Cc: Cristian Birsan, Felipe Balbi, Greg Kroah-Hartman, Nicolas Ferre,
	Ludovic Desroches, linux-arm-kernel, linux-usb, linux-kernel

On 05/08/2019 13:48:42-0500, Gustavo A. R. Silva wrote:
> Mark switch cases where we are expecting to fall through.
> 
> This patch fixes the following warning (Building: at91_dt_defconfig arm):
> 
> drivers/usb/gadget/udc/atmel_usba_udc.c:329:13: warning: this statement may fall through [-Wimplicit-fallthrough=]
> 
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

> ---
>  drivers/usb/gadget/udc/atmel_usba_udc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c
> index 503d275bc4c4..86ffc8307864 100644
> --- a/drivers/usb/gadget/udc/atmel_usba_udc.c
> +++ b/drivers/usb/gadget/udc/atmel_usba_udc.c
> @@ -327,6 +327,7 @@ static int usba_config_fifo_table(struct usba_udc *udc)
>  	switch (fifo_mode) {
>  	default:
>  		fifo_mode = 0;
> +		/* fall through */
>  	case 0:
>  		udc->fifo_cfg = NULL;
>  		n = 0;
> -- 
> 2.22.0
> 

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] usb: gadget: atmel_usba_udc: Mark expected switch fall-through
  2019-08-05 18:48 [PATCH] usb: gadget: atmel_usba_udc: Mark expected switch fall-through Gustavo A. R. Silva
  2019-08-12 14:58 ` Alexandre Belloni
@ 2019-08-16 10:27 ` Cristian.Birsan
  1 sibling, 0 replies; 3+ messages in thread
From: Cristian.Birsan @ 2019-08-16 10:27 UTC (permalink / raw)
  To: gustavo, balbi, gregkh, Nicolas.Ferre, alexandre.belloni,
	Ludovic.Desroches
  Cc: linux-arm-kernel, linux-usb, linux-kernel



On 8/5/19 9:48 PM, Gustavo A. R. Silva wrote:
> External E-Mail
> 
> 
> Mark switch cases where we are expecting to fall through.
> 
> This patch fixes the following warning (Building: at91_dt_defconfig arm):
> 
> drivers/usb/gadget/udc/atmel_usba_udc.c:329:13: warning: this statement may fall through [-Wimplicit-fallthrough=]
> 
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Acked-by: Cristian Birsan <cristian.birsan@microchip.com>

> ---
>   drivers/usb/gadget/udc/atmel_usba_udc.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c
> index 503d275bc4c4..86ffc8307864 100644
> --- a/drivers/usb/gadget/udc/atmel_usba_udc.c
> +++ b/drivers/usb/gadget/udc/atmel_usba_udc.c
> @@ -327,6 +327,7 @@ static int usba_config_fifo_table(struct usba_udc *udc)
>   	switch (fifo_mode) {
>   	default:
>   		fifo_mode = 0;
> +		/* fall through */
>   	case 0:
>   		udc->fifo_cfg = NULL;
>   		n = 0;
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-05 18:48 [PATCH] usb: gadget: atmel_usba_udc: Mark expected switch fall-through Gustavo A. R. Silva
2019-08-12 14:58 ` Alexandre Belloni
2019-08-16 10:27 ` Cristian.Birsan

Linux-USB Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-usb/0 linux-usb/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-usb linux-usb/ https://lore.kernel.org/linux-usb \
		linux-usb@vger.kernel.org linux-usb@archiver.kernel.org
	public-inbox-index linux-usb

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-usb


AGPL code for this site: git clone https://public-inbox.org/ public-inbox