From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E370FC31E40 for ; Thu, 15 Aug 2019 09:49:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C4DF8206C1 for ; Thu, 15 Aug 2019 09:49:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730389AbfHOJtY (ORCPT ); Thu, 15 Aug 2019 05:49:24 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:38796 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728464AbfHOJtY (ORCPT ); Thu, 15 Aug 2019 05:49:24 -0400 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id 667D880C11; Thu, 15 Aug 2019 11:49:09 +0200 (CEST) Date: Thu, 15 Aug 2019 11:49:22 +0200 From: Pavel Machek To: Tony Lindgren Cc: Johan Hovold , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, =?iso-8859-1?Q?Bj=F8rn?= Mork , Dan Williams , Lars Melin , Marcel Partap , Merlijn Wajer , Michael Scott , NeKit , Sebastian Reichel Subject: Re: [PATCHv2] USB: serial: option: Add Motorola modem UARTs Message-ID: <20190815094922.GB11427@amd> References: <20190815082602.51765-1-tony@atomide.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="rS8CxjVDS/+yyDmU" Content-Disposition: inline In-Reply-To: <20190815082602.51765-1-tony@atomide.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org --rS8CxjVDS/+yyDmU Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu 2019-08-15 01:26:02, Tony Lindgren wrote: > On Motorola Mapphone devices such as Droid 4 there are five USB ports > that do not use the same layout as Gobi 1K/2K/etc devices listed in > qcserial.c. So we should use qcaux.c or option.c as noted by > Dan Williams . >=20 > As the Motorola USB serial ports have an interrupt endpoint as shown > with lsusb -v, we should use option.c instead of qcaux.c as pointed out > by Johan Hovold . >=20 > The ff/ff/ff interfaces seem to always be UARTs on Motorola devices. > For the other interfaces, class 0x0a (CDC Data) should not in general > be added as they are typically part of a multi-interface function as > noted earlier by Bj=F8rn Mork . Acked-by: Pavel Machek > Cc: Sebastian Reichel > Tested-by: Pavel Machek > Signed-off-by: Tony Lingren --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --rS8CxjVDS/+yyDmU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAl1VKqIACgkQMOfwapXb+vJ+YwCeOiINkTCJCV7hE+8e3sPOiUW8 Y5QAoIYZz3Ln70nhSt3ikoVxqRegCq93 =k4Po -----END PGP SIGNATURE----- --rS8CxjVDS/+yyDmU--