From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32214C3A59D for ; Mon, 19 Aug 2019 10:59:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0F90320844 for ; Mon, 19 Aug 2019 10:59:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726893AbfHSK7R (ORCPT ); Mon, 19 Aug 2019 06:59:17 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:43909 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726550AbfHSK7R (ORCPT ); Mon, 19 Aug 2019 06:59:17 -0400 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1hzfNb-00017A-0A; Mon, 19 Aug 2019 12:59:15 +0200 Received: from ukl by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1hzfNa-0005Gc-AA; Mon, 19 Aug 2019 12:59:14 +0200 Date: Mon, 19 Aug 2019 12:59:14 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Greg KH Cc: Richard Leitner , linux-usb@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH] usb: usb251xb: drop some unused defines Message-ID: <20190819105914.bhertupbr6kwx3j5@pengutronix.de> References: <20190819100211.26791-1-u.kleine-koenig@pengutronix.de> <20190819104104.GA6530@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190819104104.GA6530@kroah.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-usb@vger.kernel.org Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Mon, Aug 19, 2019 at 12:41:04PM +0200, Greg KH wrote: > On Mon, Aug 19, 2019 at 12:02:11PM +0200, Uwe Kleine-König wrote: > > Signed-off-by: Uwe Kleine-König > > --- > > drivers/usb/misc/usb251xb.c | 5 ----- > > 1 file changed, 5 deletions(-) > > I can't take a patch without any changelog text. So I am supposed to repeat the Subject's content in the body? I completely agree that an expressive changelog is important for changes that actually change something. But it seems silly to me to describe something trivial in more words than necessary. There is zero added value; only added noise. > And you forgot to cc: the usb maintainer, so there's no way this was > going to get merged :) I would have expected that it is fine to direct to the contacts listed in the "MICROCHIP USB251XB DRIVER" section of MAINTAINERS and then let the people there care for forwarding. (And other than that it seems I catched the attention of the usb maintainer :-) Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |