* [PATCH] typec: tcpm: fix a typo in the comparison of pdo_max_voltage
@ 2019-08-22 13:52 Colin King
2019-08-22 13:59 ` Guenter Roeck
2019-08-22 15:35 ` Heikki Krogerus
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2019-08-22 13:52 UTC (permalink / raw)
To: Badhri Jagan Sridharan, Guenter Roeck, Heikki Krogerus,
Greg Kroah-Hartman, linux-usb
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
There appears to be a typo in the comparison of pdo_max_voltage[i]
with the previous value, currently it is checking against the
array pdo_min_voltage rather than pdo_max_voltage. I believe this
is a typo. Fix this.
Addresses-Coverity: ("Copy-paste error")
Fixes: 5007e1b5db73 ("typec: tcpm: Validate source and sink caps")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/usb/typec/tcpm/tcpm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
index 166b28562395..96562744101c 100644
--- a/drivers/usb/typec/tcpm/tcpm.c
+++ b/drivers/usb/typec/tcpm/tcpm.c
@@ -1439,7 +1439,7 @@ static enum pdo_err tcpm_caps_err(struct tcpm_port *port, const u32 *pdo,
else if ((pdo_min_voltage(pdo[i]) ==
pdo_min_voltage(pdo[i - 1])) &&
(pdo_max_voltage(pdo[i]) ==
- pdo_min_voltage(pdo[i - 1])))
+ pdo_max_voltage(pdo[i - 1])))
return PDO_ERR_DUPE_PDO;
break;
/*
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] typec: tcpm: fix a typo in the comparison of pdo_max_voltage
2019-08-22 13:52 [PATCH] typec: tcpm: fix a typo in the comparison of pdo_max_voltage Colin King
@ 2019-08-22 13:59 ` Guenter Roeck
2019-08-22 15:35 ` Heikki Krogerus
1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2019-08-22 13:59 UTC (permalink / raw)
To: Colin King
Cc: Badhri Jagan Sridharan, Heikki Krogerus, Greg Kroah-Hartman,
linux-usb, kernel-janitors, linux-kernel
On Thu, Aug 22, 2019 at 02:52:12PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> There appears to be a typo in the comparison of pdo_max_voltage[i]
> with the previous value, currently it is checking against the
> array pdo_min_voltage rather than pdo_max_voltage. I believe this
> is a typo. Fix this.
>
> Addresses-Coverity: ("Copy-paste error")
> Fixes: 5007e1b5db73 ("typec: tcpm: Validate source and sink caps")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
I think you are correct.
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/usb/typec/tcpm/tcpm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
> index 166b28562395..96562744101c 100644
> --- a/drivers/usb/typec/tcpm/tcpm.c
> +++ b/drivers/usb/typec/tcpm/tcpm.c
> @@ -1439,7 +1439,7 @@ static enum pdo_err tcpm_caps_err(struct tcpm_port *port, const u32 *pdo,
> else if ((pdo_min_voltage(pdo[i]) ==
> pdo_min_voltage(pdo[i - 1])) &&
> (pdo_max_voltage(pdo[i]) ==
> - pdo_min_voltage(pdo[i - 1])))
> + pdo_max_voltage(pdo[i - 1])))
> return PDO_ERR_DUPE_PDO;
> break;
> /*
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] typec: tcpm: fix a typo in the comparison of pdo_max_voltage
2019-08-22 13:52 [PATCH] typec: tcpm: fix a typo in the comparison of pdo_max_voltage Colin King
2019-08-22 13:59 ` Guenter Roeck
@ 2019-08-22 15:35 ` Heikki Krogerus
1 sibling, 0 replies; 3+ messages in thread
From: Heikki Krogerus @ 2019-08-22 15:35 UTC (permalink / raw)
To: Colin King
Cc: Badhri Jagan Sridharan, Guenter Roeck, Greg Kroah-Hartman,
linux-usb, kernel-janitors, linux-kernel
On Thu, Aug 22, 2019 at 02:52:12PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> There appears to be a typo in the comparison of pdo_max_voltage[i]
> with the previous value, currently it is checking against the
> array pdo_min_voltage rather than pdo_max_voltage. I believe this
> is a typo. Fix this.
>
> Addresses-Coverity: ("Copy-paste error")
> Fixes: 5007e1b5db73 ("typec: tcpm: Validate source and sink caps")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/typec/tcpm/tcpm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
> index 166b28562395..96562744101c 100644
> --- a/drivers/usb/typec/tcpm/tcpm.c
> +++ b/drivers/usb/typec/tcpm/tcpm.c
> @@ -1439,7 +1439,7 @@ static enum pdo_err tcpm_caps_err(struct tcpm_port *port, const u32 *pdo,
> else if ((pdo_min_voltage(pdo[i]) ==
> pdo_min_voltage(pdo[i - 1])) &&
> (pdo_max_voltage(pdo[i]) ==
> - pdo_min_voltage(pdo[i - 1])))
> + pdo_max_voltage(pdo[i - 1])))
> return PDO_ERR_DUPE_PDO;
> break;
> /*
> --
> 2.20.1
thanks,
--
heikki
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-22 15:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-22 13:52 [PATCH] typec: tcpm: fix a typo in the comparison of pdo_max_voltage Colin King
2019-08-22 13:59 ` Guenter Roeck
2019-08-22 15:35 ` Heikki Krogerus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).