From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Jorge Ramirez <jorge.ramirez-ortiz@linaro.org>,
robh@kernel.org, andy.gross@linaro.org, shawn.guo@linaro.org,
gregkh@linuxfoundation.org, mark.rutland@arm.com, kishon@ti.com,
jackp@codeaurora.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, khasim.mohammed@linaro.org
Subject: Re: [PATCH v4 3/4] dt-bindings: Add Qualcomm USB SuperSpeed PHY bindings
Date: Fri, 30 Aug 2019 09:45:20 -0700 [thread overview]
Message-ID: <20190830164520.GK26807@tuxbook-pro> (raw)
In-Reply-To: <5d694878.1c69fb81.5f13b.ec4f@mx.google.com>
On Fri 30 Aug 09:01 PDT 2019, Stephen Boyd wrote:
> Quoting Jorge Ramirez (2019-08-29 00:03:48)
> > On 2/23/19 17:52, Bjorn Andersson wrote:
> > > On Thu 07 Feb 03:17 PST 2019, Jorge Ramirez-Ortiz wrote:
> > >> +
> > >> +Required child nodes:
> > >> +
> > >> +- usb connector node as defined in bindings/connector/usb-connector.txt
> > >> + containing the property vbus-supply.
> > >> +
> > >> +Example:
> > >> +
> > >> +usb3_phy: usb3-phy@78000 {
> > >> + compatible = "qcom,snps-usb-ssphy";
> > >> + reg = <0x78000 0x400>;
> > >> + #phy-cells = <0>;
> > >> + clocks = <&rpmcc RPM_SMD_LN_BB_CLK>,
> > >> + <&gcc GCC_USB_HS_PHY_CFG_AHB_CLK>,
> > >> + <&gcc GCC_USB3_PHY_PIPE_CLK>;
> > >> + clock-names = "ref", "phy", "pipe";
> > >> + resets = <&gcc GCC_USB3_PHY_BCR>,
> > >> + <&gcc GCC_USB3PHY_PHY_BCR>;
> > >> + reset-names = "com", "phy";
> > >> + vdd-supply = <&vreg_l3_1p05>;
> > >> + vdda1p8-supply = <&vreg_l5_1p8>;
> > >> + usb3_c_connector: usb3-c-connector {
>
> Node name should be 'connector', not usb3-c-connector.
>
It probably has to be usb-c-connector, because we have a
micro-usb-connector on the same board.
> > >
> > > The USB-C connector is attached both to the HS and SS PHYs, so I think
> > > you should represent this external to this node and use of_graph to
> > > query it.
> >
> > but AFAICS we wont be able to retrieve the vbux-supply from an external
> > node (that interface does not exist).
> >
> > rob, do you have a suggestion?
>
> Shouldn't the vbus supply be in the phy? Or is this a situation where
> the phy itself doesn't have the vbus supply going to it because the PMIC
> gets in the way and handles the vbus for the connector by having the SoC
> communicate with the PMIC about when to turn the vbus on and off, etc?
>
That's correct, the VBUS comes out of the PMIC and goes directly to the
connector.
The additional complicating factor here is that the connector is wired
to a USB2 phy as well, so we need to wire up detection and vbus control
to both of them - but I think this will be fine, if we can only figure
out a sane way of getting hold of the vbus-supply.
Regards,
Bjorn
next prev parent reply other threads:[~2019-08-30 16:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190207111734.24171-1-jorge.ramirez-ortiz@linaro.org>
2019-02-07 11:17 ` [v4,3/4] dt-bindings: Add Qualcomm USB SuperSpeed PHY bindings Jorge Ramirez
2019-02-23 16:52 ` Bjorn Andersson
2019-08-29 7:03 ` [PATCH v4 3/4] " Jorge Ramirez
2019-08-30 16:01 ` Stephen Boyd
2019-08-30 16:45 ` Bjorn Andersson [this message]
2019-08-30 18:28 ` Stephen Boyd
2019-09-02 6:23 ` Jorge Ramirez
2019-09-03 17:39 ` Jack Pham
2019-09-03 21:45 ` Stephen Boyd
2019-09-03 23:34 ` Bjorn Andersson
2019-09-05 7:18 ` Jorge Ramirez
2019-09-05 17:58 ` Jack Pham
2019-09-06 5:26 ` Stephen Boyd
2019-09-06 18:25 ` Bjorn Andersson
2019-09-06 20:40 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190830164520.GK26807@tuxbook-pro \
--to=bjorn.andersson@linaro.org \
--cc=andy.gross@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jackp@codeaurora.org \
--cc=jorge.ramirez-ortiz@linaro.org \
--cc=khasim.mohammed@linaro.org \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh@kernel.org \
--cc=shawn.guo@linaro.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).