From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7CB0C432C1 for ; Wed, 25 Sep 2019 08:06:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 79031214D9 for ; Wed, 25 Sep 2019 08:06:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569398812; bh=/Znp7D1dz9B58SK7udegzOwFQa65JUJy+HSYlMuTWW4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=c1xm3EyKPJhwED6/KpDs/uwHxEt9JRcWXz5Lc2q2l79JsrAR990C9bdYG4X6hEjWT 9IEGZgokyicHAoMX6AuN75f17/ZhcXFopC/z5oN+hx0wcijF4QBnJ9YFulfh9GIPFo kZ6lwnmg0Q44D52z0NZtOSxTqRxy+SPZuVJHovXM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405731AbfIYIGw (ORCPT ); Wed, 25 Sep 2019 04:06:52 -0400 Received: from mail-lj1-f193.google.com ([209.85.208.193]:39094 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404849AbfIYIGv (ORCPT ); Wed, 25 Sep 2019 04:06:51 -0400 Received: by mail-lj1-f193.google.com with SMTP id y3so4626590ljj.6 for ; Wed, 25 Sep 2019 01:06:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=tkuY8ncEO85ojbwLeZKZIIcu93CM2pHc6dchLHrkx54=; b=IN0yTzV/DaVeYV7gtrHTUqC6PVSMwNeArm6PceJ1kedxmgAjSt3CXDK+qpV8wCurnH bC/0hqR9j34YQejfOqmpx9jRFyLEaGeb311KYPXPF0OxAzvQO/ks0l7SKfGtoPkxB0+M ubgUYwar3ZkZlgQ0pD4OXyl7puZXv6n5ZpjLPyRimmmW5R0Br7D20RfDmBF31VCqNVCe IW1BR9w0cOncmwsYg0Cj0QWHeOQH4/EMVt3ylVhPRu1c43ibTVN5MGvPaAHLiWoH7IPM AbjgTk3BvaaXVcTfU4mg+2JPgEojZr7ps0UkBCNlBZLF6Wo1M+9pBv0fh5Hr4//HeO7Y Q/mw== X-Gm-Message-State: APjAAAWwDbPncJb+ubJq79+Kvm1fV0gbINpr7+EzP9uWGfr4Mh+KKeuk Qtyr/D3217jlTvoq8GOFIQo= X-Google-Smtp-Source: APXvYqyQFnq7/cJo2ZkeON0XfTngoJpmW2DiFDNkq5+kBuk0HNMaBUlszxYHZI1M9Nxf/w+ojn+eOg== X-Received: by 2002:a2e:9693:: with SMTP id q19mr4986660lji.12.1569398809649; Wed, 25 Sep 2019 01:06:49 -0700 (PDT) Received: from xi.terra (c-51f1e055.07-184-6d6c6d4.bbcust.telenor.se. [85.224.241.81]) by smtp.gmail.com with ESMTPSA id q14sm1021599ljc.7.2019.09.25.01.06.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Sep 2019 01:06:48 -0700 (PDT) Received: from johan by xi.terra with local (Exim 4.92.2) (envelope-from ) id 1iD2K6-0003uI-I5; Wed, 25 Sep 2019 10:06:54 +0200 Date: Wed, 25 Sep 2019 10:06:54 +0200 From: Johan Hovold To: Charles Yeh Cc: Johan Hovold , Greg KH , linux-usb@vger.kernel.org, =?utf-8?B?WWVoLkNoYXJsZXMgW+iRieamrumRq10=?= Subject: Re: [PATCH] [PATCH v7] USB: serial: pl2303: Add new PID to support PL2303HXN (TYPE_HXN) Message-ID: <20190925080654.GC14159@localhost> References: <20190702123006.11320-1-charlesyeh522@gmail.com> <20190716084907.GB10939@localhost> <20190920075602.GI30545@localhost> <20190923102440.GA30545@localhost> <20190923130804.GC30545@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Wed, Sep 25, 2019 at 09:20:07AM +0800, Charles Yeh wrote: > Johan Hovold 於 2019年9月23日 週一 下午9:08寫道： > > > > Yes, the above looks good. > > > > Thank you for your reply > > I have already written a new patch[v8] file, > if you have free time. Please check as soon as possible...thanks! I'll start processing patches for 5.4 next week when the merge window closes. Meanwhile you can double check that you've considered all review-feedback you've gotten so far. I don't think you ever replied to my last comment about the reset register and why I thought using plain write (not read, mask, write) was the right thing to do. Does the register always read back as 0, or does it read back as the last value written? Johan