linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Marek Behun <marek.behun@nic.cz>
Cc: linux-usb@vger.kernel.org,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Subject: Re: regression from commit "usb: host: xhci-plat: Prevent an abnormally restrictive PHY init skipping"
Date: Sat, 28 Sep 2019 11:34:37 +0200	[thread overview]
Message-ID: <20190928113437.27a42dc2@xps13> (raw)
In-Reply-To: <20190928042950.3ae07173@nic.cz>

Hi Marek,

Marek Behun <marek.behun@nic.cz> wrote on Sat, 28 Sep 2019 04:29:50
+0200:

> Hi Miquel,
> 
> I am encountering a regression caused by your commit eb6c2eb6c7fb
> "usb: host: xhci-plat: Prevent an abnormally restrictive PHY init
> skipping" [1]

Sorry for the regression.

> 
> In the Turris Mox device tree, we use both a comphy and a usb-phy, see
> [2]. I am not sure how to solve this now. You write in your commit
> message that "While there is not users of both PHY types at the same
> time, drop this limitation from the xhci-plat.c driver."

After checking, this statement was true at the time I wrote it but
with the game of patches waiting on ML before being applied, both
our changes got merged almost at the same time.

> Should I get this patch reverted or try to solve it another way?

This patch [1] should enter during the next release (part of a bigger
series), it shows how to avoid this harsh situation where we handle two
(very different) PHY types in the same way by describing better the
hardware in the DT (discussed previously with Martin).

[1] https://patchwork.kernel.org/patch/11067687/

Hope that will help?

Thanks,
Miquèl

      parent reply	other threads:[~2019-09-28  9:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-28  2:29 regression from commit "usb: host: xhci-plat: Prevent an abnormally restrictive PHY init skipping" Marek Behun
2019-09-28  2:32 ` Marek Behun
2019-09-28  9:34 ` Miquel Raynal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190928113437.27a42dc2@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=marek.behun@nic.cz \
    --cc=martin.blumenstingl@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).