From: Simon Horman <horms@verge.net.au>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: David Miller <davem@davemloft.net>,
hayeswang@realtek.com, mario.limonciello@dell.com,
linux-usb@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] r8152: Set macpassthru in reset_resume callback
Date: Sat, 5 Oct 2019 14:12:22 +0200 [thread overview]
Message-ID: <20191005121222.6szwmuc4tjws4z23@verge.net.au> (raw)
In-Reply-To: <AAD739ED-478D-42CE-A0C9-FFBD209B5E38@canonical.com>
On Sat, Oct 05, 2019 at 07:54:15PM +0800, Kai-Heng Feng wrote:
>
>
> > On Oct 5, 2019, at 19:46, Simon Horman <horms@verge.net.au> wrote:
> >
> > On Fri, Oct 04, 2019 at 08:51:04PM +0800, Kai-Heng Feng wrote:
> >> r8152 may fail to establish network connection after resume from system
> >> suspend.
> >>
> >> If the USB port connects to r8152 lost its power during system suspend,
> >> the MAC address was written before is lost. The reason is that The MAC
> >> address doesn't get written again in its reset_resume callback.
> >>
> >> So let's set MAC address again in reset_resume callback. Also remove
> >> unnecessary lock as no other locking attempt will happen during
> >> reset_resume.
> >
> > This is two separate seemingly unrelated, other than locality in the code,
> > changes. One is a fix, the other seems to be a cleanup. Perhaps they would
> > be better addressed in separate patches.
>
> rtl8152_set_mac_address() which gets called by set_ethernet_addr(), also holds the same mutex.
> So this is more then a cleanup and I should mention it in commit log.
Thanks, I agree that is a good idea.
> Kai-Heng
>
> >
> >> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> >> ---
> >> drivers/net/usb/r8152.c | 3 +--
> >> 1 file changed, 1 insertion(+), 2 deletions(-)
> >>
> >> diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
> >> index 08726090570e..cee9fef925cd 100644
> >> --- a/drivers/net/usb/r8152.c
> >> +++ b/drivers/net/usb/r8152.c
> >> @@ -4799,10 +4799,9 @@ static int rtl8152_reset_resume(struct usb_interface *intf)
> >> struct r8152 *tp = usb_get_intfdata(intf);
> >>
> >> clear_bit(SELECTIVE_SUSPEND, &tp->flags);
> >> - mutex_lock(&tp->control);
> >> tp->rtl_ops.init(tp);
> >> queue_delayed_work(system_long_wq, &tp->hw_phy_work, 0);
> >> - mutex_unlock(&tp->control);
> >> + set_ethernet_addr(tp);
> >> return rtl8152_resume(intf);
> >> }
> >>
> >> --
> >> 2.17.1
> >>
>
prev parent reply other threads:[~2019-10-05 12:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-04 12:51 [PATCH] r8152: Set macpassthru in reset_resume callback Kai-Heng Feng
2019-10-05 0:27 ` David Miller
2019-10-05 11:46 ` Simon Horman
2019-10-05 11:54 ` Kai-Heng Feng
2019-10-05 12:12 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191005121222.6szwmuc4tjws4z23@verge.net.au \
--to=horms@verge.net.au \
--cc=davem@davemloft.net \
--cc=hayeswang@realtek.com \
--cc=kai.heng.feng@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mario.limonciello@dell.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).