From: Greg KH <gregkh@linuxfoundation.org>
To: David Heinzelmann <heinzelmann.david@gmail.com>
Cc: Alan Stern <stern@rowland.harvard.edu>, linux-usb@vger.kernel.org
Subject: Re: [PATCH] Check for changed device descriptors when a connection-change occurs before validating the connection.
Date: Mon, 7 Oct 2019 17:35:38 +0200 [thread overview]
Message-ID: <20191007153538.GA985210@kroah.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1910071001230.1513-100000@iolanthe.rowland.org>
On Mon, Oct 07, 2019 at 10:01:47AM -0400, Alan Stern wrote:
> On Mon, 7 Oct 2019, David Heinzelmann wrote:
>
> > Hi,
> >
> > I hope it all fits now.
> >
> > David
> >
> >
> > From 8517ecfac0175aebba03bb0868dde652bc3c36e5 Mon Sep 17 00:00:00 2001
> > From: David Heinzelmann <heinzelmann.david@gmail.com>
> > Date: Fri, 4 Oct 2019 12:28:36 +0200
> > Subject: [PATCH v4] usb: hub: Check device descriptor before resusciation
> >
> > If a device connected to an xHCI host controller disconnects from the USB bus
> > and then reconnects, e.g. triggered by a firmware update, then the host
> > controller automatically activates the connection and the port is enabled. The
> > implementation of hub_port_connect_change() assumes that if the port is
> > enabled then nothing has changed. There is no check if the USB descriptors
> > have changed. As a result, the kernel's internal copy of the descriptors ends
> > up being incorrect and the device doesn't work properly anymore.
> >
> > The solution to the problem is for hub_port_connect_change() always to
> > check whether the device's descriptors have changed before resuscitating
> > an enabled port.
> >
> > Signed-off-by: David Heinzelmann <heinzelmann.david@gmail.com>
>
> Acked-by: Alan Stern <stern@rowland.harvard.edu>
David, can you resend this in a format that I can apply it in?
thanks,
greg k-h
next prev parent reply other threads:[~2019-10-07 15:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-20 10:36 [PATCH] Check for changed device descriptors when a connection-change occurs before validating the connection David Heinzelmann
2019-09-20 8:55 ` Greg KH
2019-09-20 13:17 ` David Heinzelmann
2019-09-20 12:15 ` Greg KH
2019-09-20 15:33 ` David Heinzelmann
2019-09-23 14:49 ` Alan Stern
2019-09-24 10:01 ` David Heinzelmann
2019-09-25 14:20 ` Alan Stern
2019-09-30 7:26 ` David Heinzelmann
2019-09-30 14:25 ` Alan Stern
2019-10-04 13:23 ` David Heinzelmann
2019-10-04 14:17 ` Alan Stern
2019-10-07 8:47 ` David Heinzelmann
2019-10-07 14:01 ` Alan Stern
2019-10-07 15:35 ` Greg KH [this message]
2019-10-08 8:09 ` [PATCH v4] usb: hub: Check device descriptor before resusciation David Heinzelmann
2019-10-08 12:55 ` Greg KH
2019-10-08 16:10 ` David Heinzelmann
2019-10-08 15:17 ` Greg KH
2019-10-09 4:46 ` [PATCH v5] " David Heinzelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191007153538.GA985210@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=heinzelmann.david@gmail.com \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).