From: Peter Chen <peter.chen@nxp.com>
To: Peter Geis <pgwipeout@gmail.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: Re: [PATCH] usb: chipidea: tegra: clean up tegra_udc flag code
Date: Wed, 9 Oct 2019 08:18:03 +0000 [thread overview]
Message-ID: <20191009081802.GB4774@b29397-desktop> (raw)
In-Reply-To: <20191002131933.6206-1-pgwipeout@gmail.com>
On 19-10-02 09:19:33, Peter Geis wrote:
> All Tegra devices handled by tegra-udc use the same flags.
> Consolidate all the entries under one roof.
>
> Signed-off-by: Peter Geis <pgwipeout@gmail.com>
>
> Acked-by: Thierry Reding <treding@nvidia.com>
> ---
> drivers/usb/chipidea/ci_hdrc_tegra.c | 22 +++++-----------------
> 1 file changed, 5 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/usb/chipidea/ci_hdrc_tegra.c b/drivers/usb/chipidea/ci_hdrc_tegra.c
> index 12025358bb3c..0c9911d44ee5 100644
> --- a/drivers/usb/chipidea/ci_hdrc_tegra.c
> +++ b/drivers/usb/chipidea/ci_hdrc_tegra.c
> @@ -24,35 +24,23 @@ struct tegra_udc_soc_info {
> unsigned long flags;
> };
>
> -static const struct tegra_udc_soc_info tegra20_udc_soc_info = {
> - .flags = CI_HDRC_REQUIRES_ALIGNED_DMA,
> -};
> -
> -static const struct tegra_udc_soc_info tegra30_udc_soc_info = {
> - .flags = CI_HDRC_REQUIRES_ALIGNED_DMA,
> -};
> -
> -static const struct tegra_udc_soc_info tegra114_udc_soc_info = {
> - .flags = CI_HDRC_REQUIRES_ALIGNED_DMA,
> -};
> -
> -static const struct tegra_udc_soc_info tegra124_udc_soc_info = {
> +static const struct tegra_udc_soc_info tegra_udc_soc_info = {
> .flags = CI_HDRC_REQUIRES_ALIGNED_DMA,
> };
>
> static const struct of_device_id tegra_udc_of_match[] = {
> {
> .compatible = "nvidia,tegra20-udc",
> - .data = &tegra20_udc_soc_info,
> + .data = &tegra_udc_soc_info,
> }, {
> .compatible = "nvidia,tegra30-udc",
> - .data = &tegra30_udc_soc_info,
> + .data = &tegra_udc_soc_info,
> }, {
> .compatible = "nvidia,tegra114-udc",
> - .data = &tegra114_udc_soc_info,
> + .data = &tegra_udc_soc_info,
> }, {
> .compatible = "nvidia,tegra124-udc",
> - .data = &tegra124_udc_soc_info,
> + .data = &tegra_udc_soc_info,
> }, {
> /* sentinel */
> }
> --
> 2.17.1
>
Applied, thanks.
--
Thanks,
Peter Chen
prev parent reply other threads:[~2019-10-09 8:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-02 13:19 [PATCH] usb: chipidea: tegra: clean up tegra_udc flag code Peter Geis
2019-10-09 8:18 ` Peter Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191009081802.GB4774@b29397-desktop \
--to=peter.chen@nxp.com \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pgwipeout@gmail.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).