Linux-USB Archive on lore.kernel.org
 help / color / Atom feed
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: linux-usb@vger.kernel.org
Subject: [PATCH v4 0/9] usb: typec: Small API improvement
Date: Fri, 11 Oct 2019 18:32:10 +0300
Message-ID: <20191011153219.35701-1-heikki.krogerus@linux.intel.com> (raw)

Hi,

I'm sending one more version of these patches to you before sending
them to Greg. There are still some fixes coming that will conflict
with patches in this series. Since I'm not in any hurry with these,
I'll wait for those fixes in this case.

The only change in this version is that I'm now checking that kmemdup
did not fail in the first patch.

Cover letter from v3:

The broken conditions in the *_store() functions should now be fixed.

Cover letter from v2:

In this version there should be no more semantic changes.

The original cover letter:

This series moves the callback members from struct typec_capabilities
to a new struct typec_operations. That removes the need for the
drivers to keep a copy of the struct typec_capabilites if they don't
need it, and struct typec_operations can probable always be
constified.

The change is small, however I think the code ends up being a bit more
cleaner looking this way. Let me know if it's OK.

thanks,

Heikki Krogerus (9):
  usb: typec: Copy everything from struct typec_capability during
    registration
  usb: typec: Introduce typec_get_drvdata()
  usb: typec: Separate the operations vector
  usb: typec: tcpm: Start using struct typec_operations
  usb: typec: tps6598x: Start using struct typec_operations
  usb: typec: ucsi: Start using struct typec_operations
  usb: typec: hd3ss3220: Start using struct typec_operations
  usb: typec: Remove the callback members from struct typec_capability
  usb: typec: Remove unused members from struct typec_capability

 drivers/usb/typec/class.c     | 42 ++++++++++++++++++++++--------
 drivers/usb/typec/hd3ss3220.c | 24 +++++++++--------
 drivers/usb/typec/tcpm/tcpm.c | 45 ++++++++++++++------------------
 drivers/usb/typec/tps6598x.c  | 49 +++++++++++++++++++----------------
 drivers/usb/typec/ucsi/ucsi.c | 22 ++++++++--------
 include/linux/usb/typec.h     | 41 ++++++++++++++++-------------
 6 files changed, 124 insertions(+), 99 deletions(-)

-- 
2.23.0


             reply index

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-11 15:32 Heikki Krogerus [this message]
2019-10-11 15:32 ` [PATCH v4 1/9] usb: typec: Copy everything from struct typec_capability during registration Heikki Krogerus
2019-10-11 17:01   ` Guenter Roeck
2019-10-11 15:32 ` [PATCH v4 2/9] usb: typec: Introduce typec_get_drvdata() Heikki Krogerus
2019-10-11 15:32 ` [PATCH v4 3/9] usb: typec: Separate the operations vector Heikki Krogerus
2019-10-11 15:32 ` [PATCH v4 4/9] usb: typec: tcpm: Start using struct typec_operations Heikki Krogerus
2019-10-11 15:32 ` [PATCH v4 5/9] usb: typec: tps6598x: " Heikki Krogerus
2019-10-11 15:32 ` [PATCH v4 6/9] usb: typec: ucsi: " Heikki Krogerus
2019-10-11 15:32 ` [PATCH v4 7/9] usb: typec: hd3ss3220: " Heikki Krogerus
2019-10-11 15:32 ` [PATCH v4 8/9] usb: typec: Remove the callback members from struct typec_capability Heikki Krogerus
2019-10-11 15:32 ` [PATCH v4 9/9] usb: typec: Remove unused " Heikki Krogerus

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191011153219.35701-1-heikki.krogerus@linux.intel.com \
    --to=heikki.krogerus@linux.intel.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux@roeck-us.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-USB Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-usb/0 linux-usb/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-usb linux-usb/ https://lore.kernel.org/linux-usb \
		linux-usb@vger.kernel.org
	public-inbox-index linux-usb

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-usb


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git