linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: "Ji-Ze Hong (Peter Hong)" <hpeter@gmail.com>
Cc: johan@kernel.org, gregkh@linuxfoundation.org,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	peter_hong@fintek.com.tw,
	"Ji-Ze Hong (Peter Hong)" <hpeter+linux_kernel@gmail.com>
Subject: Re: [PATCH V2 0/7] Add Fintek F81534A series usb-to-serial driver
Date: Wed, 23 Oct 2019 11:21:44 +0200	[thread overview]
Message-ID: <20191023092144.GR24768@localhost> (raw)
In-Reply-To: <20190923022449.10952-1-hpeter+linux_kernel@gmail.com>

On Mon, Sep 23, 2019 at 10:24:42AM +0800, Ji-Ze Hong (Peter Hong) wrote:
> The Fintek F81532A/534A/535/536 is USB-to-2/4/8/12 serial ports device
> and the serial port is default disabled when plugin computer.
> 
> The part number is a bit same with F81532/534, but F81534A series UART
> core is enhanced from F81232, not F81532/534.  
> 
> The IC is contains devices as following:
> 	1. HUB (all devices is connected with this hub)
> 	2. GPIO/Control device. (enable serial port and control all GPIOs)
> 	3. serial port 1 to x (2/4/8/12)
> 
> It's most same with F81232, the UART device is difference as follow:
> 	1. TX/RX bulk size is 128/512bytes
> 	2. RX bulk layout change:
> 		F81232: [LSR(1Byte)+DATA(1Byte)][LSR(1Byte)+DATA(1Byte)]...
> 		F81534A:[LEN][Data.....][LSR]
> 
> We'll try to do some code refacting before add F81534A series.

Make sure to always provide a changelog when sending an updated series
(either here for the entire series or below the --- line in the
individual patches).

What has changed since v1?

> Ji-Ze Hong (Peter Hong) (7):
>   USB: serial: f81232: Extract LSR handler
>   USB: serial: f81232: Add tx_empty function
>   USB: serial: f81232: Use devm_kzalloc
>   USB: serial: f81232: Add F81534A support
>   USB: serial: f81232: Set F81534A serial port with RS232 mode
>   USB: serial: f81232: Add generator for F81534A
>   USB: serial: f81232: Add gpiolib to GPIO device
> 
>  drivers/usb/serial/f81232.c | 604 ++++++++++++++++++++++++++++++++++--
>  1 file changed, 570 insertions(+), 34 deletions(-)

Johan

      parent reply	other threads:[~2019-10-23  9:21 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-23  2:24 [PATCH V2 0/7] Add Fintek F81534A series usb-to-serial driver Ji-Ze Hong (Peter Hong)
2019-09-23  2:24 ` [PATCH V2 1/7] USB: serial: f81232: Extract LSR handler Ji-Ze Hong (Peter Hong)
2019-10-23  9:23   ` Johan Hovold
2019-09-23  2:24 ` [PATCH V2 2/7] USB: serial: f81232: Add tx_empty function Ji-Ze Hong (Peter Hong)
2019-10-23  9:15   ` Johan Hovold
2019-09-23  2:24 ` [PATCH V2 3/7] USB: serial: f81232: Use devm_kzalloc Ji-Ze Hong (Peter Hong)
2019-09-23  2:24 ` [PATCH V2 4/7] USB: serial: f81232: Add F81534A support Ji-Ze Hong (Peter Hong)
2019-10-23  9:59   ` Johan Hovold
2019-09-23  2:24 ` [PATCH V2 5/7] USB: serial: f81232: Set F81534A serial port with RS232 mode Ji-Ze Hong (Peter Hong)
2019-10-23 11:53   ` Johan Hovold
2019-10-24  8:52     ` Ji-Ze Hong (Peter Hong)
2020-01-08 14:35       ` Johan Hovold
     [not found]         ` <3c79f786-de34-550e-3964-d7fb334f6d56@gmail.com>
2020-01-13 15:17           ` Johan Hovold
2020-01-14  1:08             ` Ji-Ze Hong (Peter Hong)
2019-09-23  2:24 ` [PATCH V2 6/7] USB: serial: f81232: Add generator for F81534A Ji-Ze Hong (Peter Hong)
2019-10-23 12:05   ` Johan Hovold
2019-10-23 12:25   ` Johan Hovold
2019-09-23  2:24 ` [PATCH V2 7/7] USB: serial: f81232: Add gpiolib to GPIO device Ji-Ze Hong (Peter Hong)
2019-10-23 12:22   ` Johan Hovold
2019-10-30  2:00     ` Ji-Ze Hong (Peter Hong)
2020-01-08 14:46       ` Johan Hovold
2020-01-09  2:43         ` Ji-Ze Hong (Peter Hong)
2020-01-13 15:24           ` Johan Hovold
2019-10-23  9:21 ` Johan Hovold [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191023092144.GR24768@localhost \
    --to=johan@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hpeter+linux_kernel@gmail.com \
    --cc=hpeter@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=peter_hong@fintek.com.tw \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).