From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D02F3CA9EC4 for ; Tue, 29 Oct 2019 16:41:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A595F21721 for ; Tue, 29 Oct 2019 16:41:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390510AbfJ2QlV (ORCPT ); Tue, 29 Oct 2019 12:41:21 -0400 Received: from mx2.suse.de ([195.135.220.15]:48320 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2390425AbfJ2QlU (ORCPT ); Tue, 29 Oct 2019 12:41:20 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 84860B57D; Tue, 29 Oct 2019 16:41:18 +0000 (UTC) Date: Tue, 29 Oct 2019 17:41:16 +0100 From: Daniel Wagner To: Stefan Wahren Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Woojung Huh , Marc Zyngier , Andrew Lunn , Jisheng Zhang , Sebastian Andrzej Siewior , Thomas Gleixner , David Miller Subject: Re: [PATCH] net: usb: lan78xx: Disable interrupts before calling generic_handle_irq() Message-ID: <20191029164116.44px7mtwrauquurz@beryllium.lan> References: <20191025080413.22665-1-dwagner@suse.de> <46b35c32-4383-c630-3c52-b59bf7908c36@gmx.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <46b35c32-4383-c630-3c52-b59bf7908c36@gmx.net> User-Agent: NeoMutt/20180716 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Hi Stefan, On Sun, Oct 27, 2019 at 01:14:41PM +0100, Stefan Wahren wrote: > did you ever see this pseudo lan78xx-irqs fire? I examined > /proc/interrupts on RPi 3B+ and always saw a 0. # cat /proc/interrupts CPU0 CPU1 CPU2 CPU3 2: 15 10 20 14 ARMCTRL-level 1 Edge 3f00b880.mailbox 41: 127709 127690 127596 127783 ARMCTRL-level 41 Edge 3f980000.usb, dwc2_hsotg:usb1 61: 219 208 183 192 ARMCTRL-level 61 Edge ttyS1 65: 1285 1340 2112 1483 ARMCTRL-level 88 Edge mmc0 71: 11 15 13 13 ARMCTRL-level 94 Edge mmc1 147: 2823 2995 3648 3615 bcm2836-timer 1 Edge arch_timer 148: 0 0 0 0 bcm2836-timer 3 Edge kvm guest timer 150: 0 1 2 0 lan78xx-irqs 17 Edge usb-001:004:01 IPI0: 11102 11331 12204 11011 Rescheduling interrupts IPI1: 34 537 547 523 Function call interrupts IPI2: 0 0 0 0 CPU stop interrupts IPI3: 0 0 0 0 CPU stop (for crash dump) interrupts IPI4: 0 0 0 0 Timer broadcast interrupts IPI5: 0 0 0 0 IRQ work interrupts IPI6: 0 0 0 0 CPU wake-up interrupts Yes, this seems to work now fine with the current version. Thanks, Daniel