From: Vinod Koul <vkoul@kernel.org>
To: Mathias Nyman <mathias.nyman@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-arm-msm@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Vinod Koul <vkoul@kernel.org>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
Christian Lamparter <chunkeey@googlemail.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v5 4/4] usb: xhci: provide a debugfs hook for erasing rom
Date: Wed, 6 Nov 2019 14:08:43 +0530 [thread overview]
Message-ID: <20191106083843.1718437-5-vkoul@kernel.org> (raw)
In-Reply-To: <20191106083843.1718437-1-vkoul@kernel.org>
run "echo 1 > /sys/kernel/debug/renesas-usb/rom_erase" to erase firmware
when driver is loaded.
Subsequent init of driver shall reload the firmware
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
drivers/usb/host/xhci-pci.c | 34 ++++++++++++++++++++++++++++++++++
1 file changed, 34 insertions(+)
diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
index 4d0c0fd18c23..ac8f433861e9 100644
--- a/drivers/usb/host/xhci-pci.c
+++ b/drivers/usb/host/xhci-pci.c
@@ -14,6 +14,7 @@
#include <linux/acpi.h>
#include <linux/firmware.h>
#include <linux/unaligned/access_ok.h>
+#include <linux/debugfs.h>
#include "xhci.h"
#include "xhci-trace.h"
@@ -493,6 +494,8 @@ static int renesas_fw_verify(struct pci_dev *dev,
return 0;
}
+static void debugfs_init(struct pci_dev *pdev);
+
static int renesas_check_rom_state(struct pci_dev *pdev)
{
const struct renesas_fw_entry *entry;
@@ -516,6 +519,7 @@ static int renesas_check_rom_state(struct pci_dev *pdev)
if (version == entry->expected_version) {
dev_dbg(&pdev->dev, "Detected valid ROM version..\n");
valid_version = true;
+ debugfs_init(pdev);
}
}
if (valid_version == false)
@@ -803,6 +807,34 @@ static void renesas_rom_erase(struct pci_dev *pdev)
dev_dbg(&pdev->dev, "ROM Erase... Done success\n");
}
+static int debugfs_rom_erase(void *data, u64 value)
+{
+ struct pci_dev *pdev = data;
+
+ if (value == 1) {
+ dev_dbg(&pdev->dev, "Userspace requested ROM erase\n");
+ renesas_rom_erase(pdev);
+ return 0;
+ }
+ return -EINVAL;
+}
+DEFINE_DEBUGFS_ATTRIBUTE(rom_erase_ops, NULL, debugfs_rom_erase, "%llu\n");
+
+static struct dentry *debugfs_root;
+
+static void debugfs_init(struct pci_dev *pdev)
+{
+ debugfs_root = debugfs_create_dir("renesas-usb", NULL);
+
+ debugfs_create_file("rom_erase", 0200, debugfs_root,
+ pdev, &rom_erase_ops);
+}
+
+static void debugfs_exit(void)
+{
+ debugfs_remove_recursive(debugfs_root);
+}
+
static bool renesas_download_rom(struct pci_dev *pdev,
const u32 *fw, size_t step)
{
@@ -1248,6 +1280,8 @@ static void xhci_pci_remove(struct pci_dev *dev)
{
struct xhci_hcd *xhci;
+ debugfs_exit();
+
if (renesas_fw_alive_check(dev)) {
/*
* bail out early, if this was a renesas device w/o FW.
--
2.23.0
next prev parent reply other threads:[~2019-11-06 8:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 8:38 [PATCH v5 0/4] usb: xhci: Add support for Renesas USB controllers Vinod Koul
2019-11-06 8:38 ` [PATCH v5 1/4] usb: xhci: add firmware loader for uPD720201 and uPD720202 w/o ROM Vinod Koul
2019-11-06 8:38 ` [PATCH v5 2/4] usb: xhci: Add ROM loader for uPD720201 Vinod Koul
2019-11-06 8:38 ` [PATCH v5 3/4] usb: xhci: allow multiple firmware versions Vinod Koul
2019-11-06 8:38 ` Vinod Koul [this message]
2019-11-21 4:54 ` [PATCH v5 0/4] usb: xhci: Add support for Renesas USB controllers Vinod Koul
2019-11-26 15:59 ` Mathias Nyman
2019-12-06 4:21 ` Vinod Koul
2020-01-07 19:51 ` John Stultz
2020-01-08 4:07 ` Vinod Koul
2020-01-08 6:24 ` Greg Kroah-Hartman
2020-01-08 16:00 ` Mathias Nyman
2020-01-08 18:29 ` Greg Kroah-Hartman
2020-01-09 12:09 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191106083843.1718437-5-vkoul@kernel.org \
--to=vkoul@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=chunkeey@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).