From: Phong Tran <tranmanphong@gmail.com>
To: syzbot+7dc7c28d4577bbe55b10@syzkaller.appspotmail.com,
davem@davemloft.net, gregkh@linuxfoundation.org
Cc: glider@google.com, hslester96@gmail.com,
kstewart@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, netdev@vger.kernel.org,
syzkaller-bugs@googlegroups.com, tglx@linutronix.de,
linux-kernel-mentees@lists.linuxfoundation.org,
Phong Tran <tranmanphong@gmail.com>
Subject: [PATCH] usb: asix: Fix uninit-value in asix_mdio_write
Date: Thu, 7 Nov 2019 07:44:04 +0700 [thread overview]
Message-ID: <20191107004404.23707-1-tranmanphong@gmail.com> (raw)
In-Reply-To: <0000000000009763320594f993ee@google.com>
The local variables use without initilization value.
This fixes the syzbot report.
Reported-by: syzbot+7dc7c28d4577bbe55b10@syzkaller.appspotmail.com
Test result:
https://groups.google.com/d/msg/syzkaller-bugs/3H_n05x_sPU/sUoHhxgAAgAJ
Signed-off-by: Phong Tran <tranmanphong@gmail.com>
---
drivers/net/usb/asix_common.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/net/usb/asix_common.c b/drivers/net/usb/asix_common.c
index e39f41efda3e..3c7ccd8a9da8 100644
--- a/drivers/net/usb/asix_common.c
+++ b/drivers/net/usb/asix_common.c
@@ -444,8 +444,8 @@ void asix_set_multicast(struct net_device *net)
int asix_mdio_read(struct net_device *netdev, int phy_id, int loc)
{
struct usbnet *dev = netdev_priv(netdev);
- __le16 res;
- u8 smsr;
+ __le16 res = 0;
+ u8 smsr = 0;
int i = 0;
int ret;
@@ -478,7 +478,7 @@ void asix_mdio_write(struct net_device *netdev, int phy_id, int loc, int val)
{
struct usbnet *dev = netdev_priv(netdev);
__le16 res = cpu_to_le16(val);
- u8 smsr;
+ u8 smsr = 0;
int i = 0;
int ret;
@@ -508,8 +508,8 @@ void asix_mdio_write(struct net_device *netdev, int phy_id, int loc, int val)
int asix_mdio_read_nopm(struct net_device *netdev, int phy_id, int loc)
{
struct usbnet *dev = netdev_priv(netdev);
- __le16 res;
- u8 smsr;
+ __le16 res = 0;
+ u8 smsr = 0;
int i = 0;
int ret;
@@ -543,7 +543,7 @@ asix_mdio_write_nopm(struct net_device *netdev, int phy_id, int loc, int val)
{
struct usbnet *dev = netdev_priv(netdev);
__le16 res = cpu_to_le16(val);
- u8 smsr;
+ u8 smsr = 0;
int i = 0;
int ret;
--
2.20.1
next prev parent reply other threads:[~2019-11-07 0:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-15 21:22 KMSAN: uninit-value in asix_mdio_write syzbot
2019-11-07 0:44 ` Phong Tran [this message]
2019-11-07 23:21 ` [PATCH] usb: asix: Fix " David Miller
2019-11-10 14:07 ` [[Patch V2]] usb: asix: cleanup the buffer in asix_read_cmd Phong Tran
2019-11-10 14:11 ` Re: [PATCH] usb: asix: Fix uninit-value in asix_mdio_write Phong Tran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191107004404.23707-1-tranmanphong@gmail.com \
--to=tranmanphong@gmail.com \
--cc=davem@davemloft.net \
--cc=glider@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=hslester96@gmail.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=syzbot+7dc7c28d4577bbe55b10@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).