Linux-USB Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH 1/2] USB: serial: mos7720: fix remote wakeup
@ 2019-11-07 13:21 Johan Hovold
  2019-11-07 13:21 ` [PATCH 2/2] USB: serial: mos7840: " Johan Hovold
  2019-11-11 13:28 ` [PATCH 1/2] USB: serial: mos7720: " Greg KH
  0 siblings, 2 replies; 4+ messages in thread
From: Johan Hovold @ 2019-11-07 13:21 UTC (permalink / raw)
  To: Johan Hovold; +Cc: linux-usb, stable

The driver was setting the device remote-wakeup feature during probe in
violation of the USB specification (which says it should only be set
just prior to suspending the device). This could potentially waste
power during suspend as well as lead to spurious wakeups.

Note that USB core would clear the remote-wakeup feature at first
resume.

Fixes: 0f64478cbc7a ("USB: add USB serial mos7720 driver")
Cc: stable <stable@vger.kernel.org>     # 2.6.19
Signed-off-by: Johan Hovold <johan@kernel.org>
---
 drivers/usb/serial/mos7720.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/usb/serial/mos7720.c b/drivers/usb/serial/mos7720.c
index 18110225d506..2ec4eeacebc7 100644
--- a/drivers/usb/serial/mos7720.c
+++ b/drivers/usb/serial/mos7720.c
@@ -1833,10 +1833,6 @@ static int mos7720_startup(struct usb_serial *serial)
 	product = le16_to_cpu(serial->dev->descriptor.idProduct);
 	dev = serial->dev;
 
-	/* setting configuration feature to one */
-	usb_control_msg(serial->dev, usb_sndctrlpipe(serial->dev, 0),
-			(__u8)0x03, 0x00, 0x01, 0x00, NULL, 0x00, 5000);
-
 	if (product == MOSCHIP_DEVICE_ID_7715) {
 		struct urb *urb = serial->port[0]->interrupt_in_urb;
 
-- 
2.23.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 2/2] USB: serial: mos7840: fix remote wakeup
  2019-11-07 13:21 [PATCH 1/2] USB: serial: mos7720: fix remote wakeup Johan Hovold
@ 2019-11-07 13:21 ` " Johan Hovold
  2019-11-11 13:28   ` Greg KH
  2019-11-11 13:28 ` [PATCH 1/2] USB: serial: mos7720: " Greg KH
  1 sibling, 1 reply; 4+ messages in thread
From: Johan Hovold @ 2019-11-07 13:21 UTC (permalink / raw)
  To: Johan Hovold; +Cc: linux-usb, stable

The driver was setting the device remote-wakeup feature during probe in
violation of the USB specification (which says it should only be set
just prior to suspending the device). This could potentially waste
power during suspend as well as lead to spurious wakeups.

Note that USB core would clear the remote-wakeup feature at first
resume.

Fixes: 3f5429746d91 ("USB: Moschip 7840 USB-Serial Driver")
Cc: stable <stable@vger.kernel.org>     # 2.6.19
Signed-off-by: Johan Hovold <johan@kernel.org>
---
 drivers/usb/serial/mos7840.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c
index 3eeeee38debc..ab4bf8d6d7df 100644
--- a/drivers/usb/serial/mos7840.c
+++ b/drivers/usb/serial/mos7840.c
@@ -2290,11 +2290,6 @@ static int mos7840_port_probe(struct usb_serial_port *port)
 			goto error;
 		} else
 			dev_dbg(&port->dev, "ZLP_REG5 Writing success status%d\n", status);
-
-		/* setting configuration feature to one */
-		usb_control_msg(serial->dev, usb_sndctrlpipe(serial->dev, 0),
-				0x03, 0x00, 0x01, 0x00, NULL, 0x00,
-				MOS_WDR_TIMEOUT);
 	}
 	return 0;
 error:
-- 
2.23.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] USB: serial: mos7720: fix remote wakeup
  2019-11-07 13:21 [PATCH 1/2] USB: serial: mos7720: fix remote wakeup Johan Hovold
  2019-11-07 13:21 ` [PATCH 2/2] USB: serial: mos7840: " Johan Hovold
@ 2019-11-11 13:28 ` " Greg KH
  1 sibling, 0 replies; 4+ messages in thread
From: Greg KH @ 2019-11-11 13:28 UTC (permalink / raw)
  To: Johan Hovold; +Cc: linux-usb, stable

On Thu, Nov 07, 2019 at 02:21:18PM +0100, Johan Hovold wrote:
> The driver was setting the device remote-wakeup feature during probe in
> violation of the USB specification (which says it should only be set
> just prior to suspending the device). This could potentially waste
> power during suspend as well as lead to spurious wakeups.
> 
> Note that USB core would clear the remote-wakeup feature at first
> resume.
> 
> Fixes: 0f64478cbc7a ("USB: add USB serial mos7720 driver")
> Cc: stable <stable@vger.kernel.org>     # 2.6.19
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---
>  drivers/usb/serial/mos7720.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/usb/serial/mos7720.c b/drivers/usb/serial/mos7720.c
> index 18110225d506..2ec4eeacebc7 100644
> --- a/drivers/usb/serial/mos7720.c
> +++ b/drivers/usb/serial/mos7720.c
> @@ -1833,10 +1833,6 @@ static int mos7720_startup(struct usb_serial *serial)
>  	product = le16_to_cpu(serial->dev->descriptor.idProduct);
>  	dev = serial->dev;
>  
> -	/* setting configuration feature to one */
> -	usb_control_msg(serial->dev, usb_sndctrlpipe(serial->dev, 0),
> -			(__u8)0x03, 0x00, 0x01, 0x00, NULL, 0x00, 5000);
> -
>  	if (product == MOSCHIP_DEVICE_ID_7715) {
>  		struct urb *urb = serial->port[0]->interrupt_in_urb;
>  

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 2/2] USB: serial: mos7840: fix remote wakeup
  2019-11-07 13:21 ` [PATCH 2/2] USB: serial: mos7840: " Johan Hovold
@ 2019-11-11 13:28   ` Greg KH
  0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2019-11-11 13:28 UTC (permalink / raw)
  To: Johan Hovold; +Cc: linux-usb, stable

On Thu, Nov 07, 2019 at 02:21:19PM +0100, Johan Hovold wrote:
> The driver was setting the device remote-wakeup feature during probe in
> violation of the USB specification (which says it should only be set
> just prior to suspending the device). This could potentially waste
> power during suspend as well as lead to spurious wakeups.
> 
> Note that USB core would clear the remote-wakeup feature at first
> resume.
> 
> Fixes: 3f5429746d91 ("USB: Moschip 7840 USB-Serial Driver")
> Cc: stable <stable@vger.kernel.org>     # 2.6.19
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---
>  drivers/usb/serial/mos7840.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c
> index 3eeeee38debc..ab4bf8d6d7df 100644
> --- a/drivers/usb/serial/mos7840.c
> +++ b/drivers/usb/serial/mos7840.c
> @@ -2290,11 +2290,6 @@ static int mos7840_port_probe(struct usb_serial_port *port)
>  			goto error;
>  		} else
>  			dev_dbg(&port->dev, "ZLP_REG5 Writing success status%d\n", status);
> -
> -		/* setting configuration feature to one */
> -		usb_control_msg(serial->dev, usb_sndctrlpipe(serial->dev, 0),
> -				0x03, 0x00, 0x01, 0x00, NULL, 0x00,
> -				MOS_WDR_TIMEOUT);
>  	}
>  	return 0;
>  error:
> -- 
> 2.23.0

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-07 13:21 [PATCH 1/2] USB: serial: mos7720: fix remote wakeup Johan Hovold
2019-11-07 13:21 ` [PATCH 2/2] USB: serial: mos7840: " Johan Hovold
2019-11-11 13:28   ` Greg KH
2019-11-11 13:28 ` [PATCH 1/2] USB: serial: mos7720: " Greg KH

Linux-USB Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-usb/0 linux-usb/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-usb linux-usb/ https://lore.kernel.org/linux-usb \
		linux-usb@vger.kernel.org
	public-inbox-index linux-usb

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-usb


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git