From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AEA6C17441 for ; Mon, 11 Nov 2019 13:28:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 012C72196E for ; Mon, 11 Nov 2019 13:28:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727122AbfKKN20 (ORCPT ); Mon, 11 Nov 2019 08:28:26 -0500 Received: from mail.kernel.org ([198.145.29.99]:40860 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727103AbfKKN2Z (ORCPT ); Mon, 11 Nov 2019 08:28:25 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E131A21E6F; Mon, 11 Nov 2019 13:28:24 +0000 (UTC) Date: Mon, 11 Nov 2019 14:28:23 +0100 From: Greg KH To: Johan Hovold Cc: linux-usb@vger.kernel.org, stable Subject: Re: [PATCH 1/2] USB: serial: mos7720: fix remote wakeup Message-ID: <20191111132823.GB450958@kroah.com> References: <20191107132119.2159-1-johan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191107132119.2159-1-johan@kernel.org> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Thu, Nov 07, 2019 at 02:21:18PM +0100, Johan Hovold wrote: > The driver was setting the device remote-wakeup feature during probe in > violation of the USB specification (which says it should only be set > just prior to suspending the device). This could potentially waste > power during suspend as well as lead to spurious wakeups. > > Note that USB core would clear the remote-wakeup feature at first > resume. > > Fixes: 0f64478cbc7a ("USB: add USB serial mos7720 driver") > Cc: stable # 2.6.19 > Signed-off-by: Johan Hovold > --- > drivers/usb/serial/mos7720.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/usb/serial/mos7720.c b/drivers/usb/serial/mos7720.c > index 18110225d506..2ec4eeacebc7 100644 > --- a/drivers/usb/serial/mos7720.c > +++ b/drivers/usb/serial/mos7720.c > @@ -1833,10 +1833,6 @@ static int mos7720_startup(struct usb_serial *serial) > product = le16_to_cpu(serial->dev->descriptor.idProduct); > dev = serial->dev; > > - /* setting configuration feature to one */ > - usb_control_msg(serial->dev, usb_sndctrlpipe(serial->dev, 0), > - (__u8)0x03, 0x00, 0x01, 0x00, NULL, 0x00, 5000); > - > if (product == MOSCHIP_DEVICE_ID_7715) { > struct urb *urb = serial->port[0]->interrupt_in_urb; > Reviewed-by: Greg Kroah-Hartman