From: Greg KH <greg@kroah.com>
To: Johan Hovold <johan@kernel.org>
Cc: linux-usb@vger.kernel.org, stable <stable@vger.kernel.org>
Subject: Re: [PATCH 2/2] USB: serial: mos7840: fix remote wakeup
Date: Mon, 11 Nov 2019 14:28:29 +0100 [thread overview]
Message-ID: <20191111132829.GC450958@kroah.com> (raw)
In-Reply-To: <20191107132119.2159-2-johan@kernel.org>
On Thu, Nov 07, 2019 at 02:21:19PM +0100, Johan Hovold wrote:
> The driver was setting the device remote-wakeup feature during probe in
> violation of the USB specification (which says it should only be set
> just prior to suspending the device). This could potentially waste
> power during suspend as well as lead to spurious wakeups.
>
> Note that USB core would clear the remote-wakeup feature at first
> resume.
>
> Fixes: 3f5429746d91 ("USB: Moschip 7840 USB-Serial Driver")
> Cc: stable <stable@vger.kernel.org> # 2.6.19
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---
> drivers/usb/serial/mos7840.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c
> index 3eeeee38debc..ab4bf8d6d7df 100644
> --- a/drivers/usb/serial/mos7840.c
> +++ b/drivers/usb/serial/mos7840.c
> @@ -2290,11 +2290,6 @@ static int mos7840_port_probe(struct usb_serial_port *port)
> goto error;
> } else
> dev_dbg(&port->dev, "ZLP_REG5 Writing success status%d\n", status);
> -
> - /* setting configuration feature to one */
> - usb_control_msg(serial->dev, usb_sndctrlpipe(serial->dev, 0),
> - 0x03, 0x00, 0x01, 0x00, NULL, 0x00,
> - MOS_WDR_TIMEOUT);
> }
> return 0;
> error:
> --
> 2.23.0
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
next prev parent reply other threads:[~2019-11-11 13:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-07 13:21 [PATCH 1/2] USB: serial: mos7720: fix remote wakeup Johan Hovold
2019-11-07 13:21 ` [PATCH 2/2] USB: serial: mos7840: " Johan Hovold
2019-11-11 13:28 ` Greg KH [this message]
2019-11-11 13:28 ` [PATCH 1/2] USB: serial: mos7720: " Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191111132829.GC450958@kroah.com \
--to=greg@kroah.com \
--cc=johan@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).