From: Phong Tran <tranmanphong@gmail.com>
To: davem@davemloft.net, gregkh@linuxfoundation.org, oneukum@suse.com
Cc: alexios.zavras@intel.com, johan@kernel.org, allison@lohutok.net,
tglx@linutronix.de, benquike@gmail.com,
linux-usb@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Phong Tran <tranmanphong@gmail.com>
Subject: [PATCH 2/2] drivers: net: usbnet: Fix -Wcast-function-type
Date: Mon, 25 Nov 2019 21:54:43 +0700 [thread overview]
Message-ID: <20191125145443.29052-2-tranmanphong@gmail.com> (raw)
In-Reply-To: <20191125145443.29052-1-tranmanphong@gmail.com>
correct usage prototype of callback in tasklet_init().
Report by https://github.com/KSPP/linux/issues/20
Signed-off-by: Phong Tran <tranmanphong@gmail.com>
---
drivers/net/usb/usbnet.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
index dde05e2fdc3e..d10a5e6d0917 100644
--- a/drivers/net/usb/usbnet.c
+++ b/drivers/net/usb/usbnet.c
@@ -1573,6 +1573,12 @@ static void usbnet_bh (struct timer_list *t)
}
}
+static void usbnet_bh_tasklet (unsigned long data)
+{
+ struct timer_list *t = (struct timer_list *)data;
+ usbnet_bh(t);
+}
+
/*-------------------------------------------------------------------------
*
@@ -1700,7 +1706,7 @@ usbnet_probe (struct usb_interface *udev, const struct usb_device_id *prod)
skb_queue_head_init (&dev->txq);
skb_queue_head_init (&dev->done);
skb_queue_head_init(&dev->rxq_pause);
- dev->bh.func = (void (*)(unsigned long))usbnet_bh;
+ dev->bh.func = usbnet_bh_tasklet;
dev->bh.data = (unsigned long)&dev->delay;
INIT_WORK (&dev->kevent, usbnet_deferred_kevent);
init_usb_anchor(&dev->deferred);
--
2.20.1
next prev parent reply other threads:[~2019-11-25 14:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-25 14:54 [PATCH 1/2] drivers: net: hso: Fix -Wcast-function-type Phong Tran
2019-11-25 14:54 ` Phong Tran [this message]
2019-11-25 19:07 ` [PATCH 2/2] drivers: net: usbnet: " David Miller
2019-11-26 13:54 ` [Patch v2 0/2] Fix -Wcast-function-type usb net drivers Phong Tran
2019-11-26 13:54 ` [Patch v2 1/2] net: hso: Fix -Wcast-function-type Phong Tran
2019-11-26 13:54 ` [Patch v2 2/2] net: usbnet: " Phong Tran
2019-11-26 22:04 ` [Patch v2 0/2] Fix -Wcast-function-type usb net drivers David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191125145443.29052-2-tranmanphong@gmail.com \
--to=tranmanphong@gmail.com \
--cc=alexios.zavras@intel.com \
--cc=allison@lohutok.net \
--cc=benquike@gmail.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).