linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] drivers: net: hso: Fix -Wcast-function-type
@ 2019-11-25 14:54 Phong Tran
  2019-11-25 14:54 ` [PATCH 2/2] drivers: net: usbnet: " Phong Tran
  0 siblings, 1 reply; 7+ messages in thread
From: Phong Tran @ 2019-11-25 14:54 UTC (permalink / raw)
  To: davem, gregkh, oneukum
  Cc: alexios.zavras, johan, allison, tglx, benquike, linux-usb,
	netdev, linux-kernel, Phong Tran

correct usage prototype of callback in tasklet_init().
Report by https://github.com/KSPP/linux/issues/20

Signed-off-by: Phong Tran <tranmanphong@gmail.com>
---
 drivers/net/usb/hso.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c
index 74849da031fa..ca827802f291 100644
--- a/drivers/net/usb/hso.c
+++ b/drivers/net/usb/hso.c
@@ -1214,8 +1214,9 @@ static void hso_std_serial_read_bulk_callback(struct urb *urb)
  * This needs to be a tasklet otherwise we will
  * end up recursively calling this function.
  */
-static void hso_unthrottle_tasklet(struct hso_serial *serial)
+static void hso_unthrottle_tasklet(unsigned long data)
 {
+	struct hso_serial *serial = (struct hso_serial *)data;
 	unsigned long flags;
 
 	spin_lock_irqsave(&serial->serial_lock, flags);
@@ -1265,7 +1266,7 @@ static int hso_serial_open(struct tty_struct *tty, struct file *filp)
 		/* Force default termio settings */
 		_hso_serial_set_termios(tty, NULL);
 		tasklet_init(&serial->unthrottle_tasklet,
-			     (void (*)(unsigned long))hso_unthrottle_tasklet,
+			     hso_unthrottle_tasklet,
 			     (unsigned long)serial);
 		result = hso_start_serial_device(serial->parent, GFP_KERNEL);
 		if (result) {
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2019-11-26 22:04 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-25 14:54 [PATCH 1/2] drivers: net: hso: Fix -Wcast-function-type Phong Tran
2019-11-25 14:54 ` [PATCH 2/2] drivers: net: usbnet: " Phong Tran
2019-11-25 19:07   ` David Miller
2019-11-26 13:54     ` [Patch v2 0/2] Fix -Wcast-function-type usb net drivers Phong Tran
2019-11-26 13:54       ` [Patch v2 1/2] net: hso: Fix -Wcast-function-type Phong Tran
2019-11-26 13:54       ` [Patch v2 2/2] net: usbnet: " Phong Tran
2019-11-26 22:04       ` [Patch v2 0/2] Fix -Wcast-function-type usb net drivers David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).