From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45A20C432C0 for ; Mon, 25 Nov 2019 15:15:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1B00A2082F for ; Mon, 25 Nov 2019 15:15:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gAgopknF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728540AbfKYPP5 (ORCPT ); Mon, 25 Nov 2019 10:15:57 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:57443 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728399AbfKYPP5 (ORCPT ); Mon, 25 Nov 2019 10:15:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574694955; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FZC4Tpkk+CwwwL93QU1+o+P6o/ZYTmixyeklL1zRZCY=; b=gAgopknFzMapF6Ud3+nITuCrxdO6Qez4j2xf2AnoJN+qOmyxPtARiIyGPebVOXAONuek2F H4V5ENFfrv4DWPmfC5MM7fRHtpMnelkJ5hXFNe0GvqA80Mil9xApWF1JeDtsiXZkx/7Ayp oWAQYWQ0yMzvFXWbAXmzEDyn8oiiP74= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-204-cvZ0gjUlPAqUKcag45LBpg-1; Mon, 25 Nov 2019 10:15:52 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8B31DDB60; Mon, 25 Nov 2019 15:15:50 +0000 (UTC) Received: from ming.t460p (ovpn-8-17.pek2.redhat.com [10.72.8.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5F7621001B05; Mon, 25 Nov 2019 15:15:39 +0000 (UTC) Date: Mon, 25 Nov 2019 23:15:35 +0800 From: Ming Lei To: Andrea Vai Cc: Damien Le Moal , Alan Stern , Jens Axboe , Johannes Thumshirn , USB list , SCSI development list , Himanshu Madhani , Hannes Reinecke , Omar Sandoval , "Martin K. Petersen" , Greg KH , Hans Holmberg , Kernel development list Subject: Re: Slow I/O on USB media after commit f664a3cc17b7d0a2bc3b3ab96181e1029b0ec0e6 Message-ID: <20191125151535.GA8044@ming.t460p> References: <20191109222828.GA30568@ming.t460p> <20191123072726.GC25356@ming.t460p> <20191125035437.GA3806@ming.t460p> <20191125102928.GA20489@ming.t460p> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: cvZ0gjUlPAqUKcag45LBpg-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Mon, Nov 25, 2019 at 03:58:34PM +0100, Andrea Vai wrote: > Il giorno lun, 25/11/2019 alle 18.29 +0800, Ming Lei ha scritto: > > On Mon, Nov 25, 2019 at 11:11:00AM +0100, Andrea Vai wrote: > > > Il giorno lun, 25/11/2019 alle 11.54 +0800, Ming Lei ha scritto: > > > > On Sat, Nov 23, 2019 at 04:44:55PM +0100, Andrea Vai wrote: > > > > > Il giorno sab, 23/11/2019 alle 15.28 +0800, Ming Lei ha > > scritto: > > > > > >=20 > > > > > > Please post the log of 'lsusb -v', and I will try to make a > > > > patch > > > > > > for > > > > > > addressing the issue. > > > > >=20 > > > > > attached, > > > >=20 > > > > Please apply the attached patch, and re-build & install & reboot > > > > kernel. > > > >=20 > > > > This time, please don't switch io scheduler. > > >=20 > > > # patch -p1 < usb.patch outputs: > > >=20 > > > (Stripping trailing CRs from patch; use --binary to disable.) > > > patching file block/blk-mq.c > > > Hunk #1 succeeded at 1465 (offset 29 lines). > > > Hunk #2 succeeded at 3061 (offset 13 lines). > > > (Stripping trailing CRs from patch; use --binary to disable.) > > > patching file drivers/scsi/scsi_lib.c > > > Hunk #1 succeeded at 1902 (offset -37 lines). > > > (Stripping trailing CRs from patch; use --binary to disable.) > > > patching file drivers/usb/storage/scsiglue.c > > > Hunk #1 succeeded at 651 (offset -10 lines). > > > (Stripping trailing CRs from patch; use --binary to disable.) > > > patching file include/linux/blk-mq.h > > > Hunk #1 succeeded at 226 (offset -162 lines). > > > (Stripping trailing CRs from patch; use --binary to disable.) > > > patching file include/scsi/scsi_host.h > > > patch unexpectedly ends in middle of line > > > patch unexpectedly ends in middle of line > > >=20 > > > Just to be sure I have to go on, is this correct? Sounds like an > > error > > > but I don't know if it is important. > >=20 > > Looks there is small conflict, however it has been fixed by patch, > > so > > it is correct, please go on your test. >=20 > Done, it still fails (2000 seconds or more to copy 1GB) :-( >=20 > cat /sys/block/sdf/queue/scheduler outputs: > [mq-deadline] none >=20 > What to try next? 1) cat /sys/kernel/debug/block/$DISK/hctx0/flags note: replace $DISK with disk name of your usb drive, such as, if it is /dev/sdb, pass $DISK as sdb. 2) echo 128 > /sys/block/$DISK/queue/nr_requests and run your copy 1GB test again. Thanks,=20 Ming