From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25693C432C0 for ; Tue, 26 Nov 2019 15:47:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 08C952071E for ; Tue, 26 Nov 2019 15:47:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728002AbfKZPq6 (ORCPT ); Tue, 26 Nov 2019 10:46:58 -0500 Received: from mga11.intel.com ([192.55.52.93]:64419 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727865AbfKZPq6 (ORCPT ); Tue, 26 Nov 2019 10:46:58 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Nov 2019 07:46:57 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,246,1571727600"; d="scan'208";a="217183719" Received: from kuha.fi.intel.com ([10.237.72.53]) by fmsmga001.fm.intel.com with SMTP; 26 Nov 2019 07:46:55 -0800 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Tue, 26 Nov 2019 17:46:54 +0200 Date: Tue, 26 Nov 2019 17:46:54 +0200 From: Heikki Krogerus To: Wen Yang Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: typec: fix use after free in typec_register_port() Message-ID: <20191126154654.GA6428@kuha.fi.intel.com> References: <20191126140452.14048-1-wenyang@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20191126140452.14048-1-wenyang@linux.alibaba.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Tue, Nov 26, 2019 at 10:04:52PM +0800, Wen Yang wrote: > We can't use "port->sw" and/or "port->mux" after it has been freed. > > Fixes: 23481121c81d ("usb: typec: class: Don't use port parent for getting mux handles") > Signed-off-by: Wen Yang > Cc: Heikki Krogerus Acked-by: Heikki Krogerus  > Cc: Greg Kroah-Hartman > Cc: linux-usb@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > --- > drivers/usb/typec/class.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c > index 7ece6ca..91d6227 100644 > --- a/drivers/usb/typec/class.c > +++ b/drivers/usb/typec/class.c > @@ -1612,14 +1612,16 @@ struct typec_port *typec_register_port(struct device *parent, > > port->sw = typec_switch_get(&port->dev); > if (IS_ERR(port->sw)) { > + ret = PTR_ERR(port->sw); > put_device(&port->dev); > - return ERR_CAST(port->sw); > + return ERR_PTR(ret); > } > > port->mux = typec_mux_get(&port->dev, NULL); > if (IS_ERR(port->mux)) { > + ret = PTR_ERR(port->mux); > put_device(&port->dev); > - return ERR_CAST(port->mux); > + return ERR_PTR(ret); > } > > ret = device_add(&port->dev); > -- > 1.8.3.1 thanks, -- heikki