From: Pete Zaitcev <zaitcev@redhat.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Greg KH <greg@kroah.com>, USB list <linux-usb@vger.kernel.org>
Subject: Re: [PATCH] usb: mon: Fix a deadlock in usbmon between mmap and read
Date: Tue, 26 Nov 2019 22:35:09 -0600 [thread overview]
Message-ID: <20191126223509.69fb61ed@suzdal.zaitcev.lan> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1911261018110.1508-100000@iolanthe.rowland.org>
On Tue, 26 Nov 2019 10:20:14 -0500 (EST)
Alan Stern <stern@rowland.harvard.edu> wrote:
> > Signed-off-by: Pete Zaitcev <zaitcev@redhat.com>
> > Reported-by: syzbot+56f9673bb4cdcbeb0e92@syzkaller.appspotmail.com
>
> Reviewed-by: Alan Stern <stern@rowland.harvard.edu>
Thanks.
> Fixes: 46eb14a6e158 ("USB: fix usbmon BUG trigger")
Indeed... Either I didn't think that one through, or the copy_to_user
used not to take the mmap_sem.
> CC: <stable@vger.kernel.org>
Do we really need this? The problem was in the code for more than 10 years.
It's not like anyone is exploiting systems because of it.
If we do need it, I should cc: the submission to the same place too, right?
-- Pete
next prev parent reply other threads:[~2019-11-27 4:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-26 6:44 [PATCH] usb: mon: Fix a deadlock in usbmon between mmap and read Pete Zaitcev
2019-11-26 15:20 ` Alan Stern
2019-11-27 4:35 ` Pete Zaitcev [this message]
2019-11-27 6:55 ` Greg KH
2019-11-27 15:07 ` Alan Stern
2019-12-05 2:39 Pete Zaitcev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191126223509.69fb61ed@suzdal.zaitcev.lan \
--to=zaitcev@redhat.com \
--cc=greg@kroah.com \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).