From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A5FBC432C0 for ; Wed, 27 Nov 2019 06:55:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2A6AC20665 for ; Wed, 27 Nov 2019 06:55:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kroah.com header.i=@kroah.com header.b="FnSFx+OQ"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="UBSnBLKP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726292AbfK0GzX (ORCPT ); Wed, 27 Nov 2019 01:55:23 -0500 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:36229 "EHLO wout4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726281AbfK0GzX (ORCPT ); Wed, 27 Nov 2019 01:55:23 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id F1887948; Wed, 27 Nov 2019 01:55:21 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Wed, 27 Nov 2019 01:55:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=Fnh93xvY+sEJGHFFgEbHiCaLzHu JgzCqGygPt0+g9mM=; b=FnSFx+OQMsKAkyuj/1hUwacpAKWmzJsasgMXSjA1j7s Z5W8BXfOmk1/sharZBsrUIG/kaywz2KfpQm7oNv0dorz/sWrgb7zCmaIMpmwkxP1 EBa+DxfxDaYlRdq2U8nxxiS2h5zmw5EYd9yvCwze5J6QWPEEku3WgPTZLZqXXTim qHTSmDFTcUU1YTAM2ZokPNV2lX2t9oljkoa9N4N885NgeK3LQfobzh02sA0jH5b4 CdLoVCmAa8mxlRWCGeoLaEMH/IdP7tjAK+VwGKO+hMnQT+i9N2r89gQpTGk3AE9I 80ICzP/qUc0lP7UYv5ZEmXBCxuCWQD6DqFE2Ka+1Dgg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=Fnh93x vY+sEJGHFFgEbHiCaLzHuJgzCqGygPt0+g9mM=; b=UBSnBLKPHWBXWfuks7VVAb vzNHqyArUbW1kP6FjEVQ37kY1tn3GWsmk9D1XMwDI1k9u/7yBXWFXa4rBys+gsHg 7bRc+GIulKCE+atwe5xArTp5iJcmF2eMsxjkY5hr/kcqddDX1UkKvM51bgEyaM4G pLBLJEEL7oN5E7/y7Uwxe7NXFTL+nIMwwSPsKfcvCSfd26iZYRynZ68azi8hKYaY vctYjTbF9hspifkcPN/z/mCoWmX0dWwuXKsSvL6EfApnWK0pdR5QRc8FcYsVwlBD yDT/mI6CEcoFiEsbnxPwNrIwhuyLa+pqRnOaAgqL2qTPf/OTwUKXTJdq0NxXj1Fg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrudeigedguddttdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujggfsehttdertddtredvnecuhfhrohhmpefirhgv ghcumffjuceoghhrvghgsehkrhhorghhrdgtohhmqeenucfkphepkeefrdekiedrkeelrd dutdejnecurfgrrhgrmhepmhgrihhlfhhrohhmpehgrhgvgheskhhrohgrhhdrtghomhen ucevlhhushhtvghrufhiiigvpedu X-ME-Proxy: Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) by mail.messagingengine.com (Postfix) with ESMTPA id F360C306005C; Wed, 27 Nov 2019 01:55:20 -0500 (EST) Date: Wed, 27 Nov 2019 07:55:19 +0100 From: Greg KH To: Pete Zaitcev Cc: Alan Stern , USB list Subject: Re: [PATCH] usb: mon: Fix a deadlock in usbmon between mmap and read Message-ID: <20191127065519.GA1724976@kroah.com> References: <20191126004407.4b72ef7f@suzdal.zaitcev.lan> <20191126223509.69fb61ed@suzdal.zaitcev.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191126223509.69fb61ed@suzdal.zaitcev.lan> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Tue, Nov 26, 2019 at 10:35:09PM -0600, Pete Zaitcev wrote: > On Tue, 26 Nov 2019 10:20:14 -0500 (EST) > Alan Stern wrote: > > > > Signed-off-by: Pete Zaitcev > > > Reported-by: syzbot+56f9673bb4cdcbeb0e92@syzkaller.appspotmail.com > > > > Reviewed-by: Alan Stern > > Thanks. > > > Fixes: 46eb14a6e158 ("USB: fix usbmon BUG trigger") > > Indeed... Either I didn't think that one through, or the copy_to_user > used not to take the mmap_sem. > > > CC: > > Do we really need this? The problem was in the code for more than 10 years. > It's not like anyone is exploiting systems because of it. Well now we all have a simple reproducer for it, so yes, it should be backported. I'm doing that for all of the syzbot stuff. > If we do need it, I should cc: the submission to the same place too, right? Nope, the tag is just fine, that's all that is needed. I'll add the above to the patch when applying it to my trees. thanks, greg k-h