Linux-USB Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH 0/2] Two minor USB related fixes
@ 2019-11-28 13:43 Bryan O'Donoghue
  2019-11-28 13:43 ` [PATCH 1/2] usb: common: usb-conn-gpio: Don't log an error on probe deferral Bryan O'Donoghue
  2019-11-28 13:43 ` [PATCH 2/2] dt-bindings: connector: Improve the english of the initial description Bryan O'Donoghue
  0 siblings, 2 replies; 3+ messages in thread
From: Bryan O'Donoghue @ 2019-11-28 13:43 UTC (permalink / raw)
  To: linux-kernel, linux-usb; +Cc: Bryan O'Donoghue

This set contains two minor USB related fixes.

The first patch fixes usb-conn-gpio. We should not print out an error
message when trying to get a handle to a VBUS regulator, if it is a simple
deferral.

The second patch fixes the description of the USB connector bindings. It
reads a little funny lacking indefinite articles.

Bryan O'Donoghue (2):
  usb: common: usb-conn-gpio: Don't log an error on probe deferral
  dt-bindings: connector: Improve the english of the initial description

 Documentation/devicetree/bindings/connector/usb-connector.txt | 4 ++--
 drivers/usb/common/usb-conn-gpio.c                            | 3 ++-
 2 files changed, 4 insertions(+), 3 deletions(-)

-- 
2.24.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 1/2] usb: common: usb-conn-gpio: Don't log an error on probe deferral
  2019-11-28 13:43 [PATCH 0/2] Two minor USB related fixes Bryan O'Donoghue
@ 2019-11-28 13:43 ` Bryan O'Donoghue
  2019-11-28 13:43 ` [PATCH 2/2] dt-bindings: connector: Improve the english of the initial description Bryan O'Donoghue
  1 sibling, 0 replies; 3+ messages in thread
From: Bryan O'Donoghue @ 2019-11-28 13:43 UTC (permalink / raw)
  To: linux-kernel, linux-usb
  Cc: Bryan O'Donoghue, Chunfeng Yun, Nagarjuna Kristam,
	Linus Walleij, Greg Kroah-Hartman

This patch makes the printout of the error message for failing to get a
VBUS regulator handle conditional on the error code being something other
than -EPROBE_DEFER.

Deferral is a normal thing, we don't need an error message for this.

Cc: Chunfeng Yun <chunfeng.yun@mediatek.com>
Cc: Nagarjuna Kristam <nkristam@nvidia.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
 drivers/usb/common/usb-conn-gpio.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/common/usb-conn-gpio.c b/drivers/usb/common/usb-conn-gpio.c
index 87338f9eb5be..ed204cbb63ea 100644
--- a/drivers/usb/common/usb-conn-gpio.c
+++ b/drivers/usb/common/usb-conn-gpio.c
@@ -156,7 +156,8 @@ static int usb_conn_probe(struct platform_device *pdev)
 
 	info->vbus = devm_regulator_get(dev, "vbus");
 	if (IS_ERR(info->vbus)) {
-		dev_err(dev, "failed to get vbus\n");
+		if (PTR_ERR(info->vbus) != -EPROBE_DEFER)
+			dev_err(dev, "failed to get vbus\n");
 		return PTR_ERR(info->vbus);
 	}
 
-- 
2.24.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 2/2] dt-bindings: connector: Improve the english of the initial description
  2019-11-28 13:43 [PATCH 0/2] Two minor USB related fixes Bryan O'Donoghue
  2019-11-28 13:43 ` [PATCH 1/2] usb: common: usb-conn-gpio: Don't log an error on probe deferral Bryan O'Donoghue
@ 2019-11-28 13:43 ` Bryan O'Donoghue
  1 sibling, 0 replies; 3+ messages in thread
From: Bryan O'Donoghue @ 2019-11-28 13:43 UTC (permalink / raw)
  To: linux-kernel, linux-usb
  Cc: Bryan O'Donoghue, Andrzej Hajda, Rob Herring, Chanwoo Choi,
	devicetree

The description lacks a few indefinite articles when reading and as a
result is a bit clunky to read. Introduce a few indefinite articles to
appease the grammar gods.

Cc: Andrzej Hajda <a.hajda@samsung.com>
Cc: Rob Herring <robh@kernel.org>
Cc: Chanwoo Choi <cw00.choi@samsung.com>
Cc: linux-usb@vger.kernel.org
Cc: devicetree@vger.kernel.org
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
 Documentation/devicetree/bindings/connector/usb-connector.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/connector/usb-connector.txt b/Documentation/devicetree/bindings/connector/usb-connector.txt
index d357987181ee..88578ac1a8a7 100644
--- a/Documentation/devicetree/bindings/connector/usb-connector.txt
+++ b/Documentation/devicetree/bindings/connector/usb-connector.txt
@@ -1,8 +1,8 @@
 USB Connector
 =============
 
-USB connector node represents physical USB connector. It should be
-a child of USB interface controller.
+A USB connector node represents a physical USB connector. It should be
+a child of a USB interface controller.
 
 Required properties:
 - compatible: describes type of the connector, must be one of:
-- 
2.24.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-28 13:43 [PATCH 0/2] Two minor USB related fixes Bryan O'Donoghue
2019-11-28 13:43 ` [PATCH 1/2] usb: common: usb-conn-gpio: Don't log an error on probe deferral Bryan O'Donoghue
2019-11-28 13:43 ` [PATCH 2/2] dt-bindings: connector: Improve the english of the initial description Bryan O'Donoghue

Linux-USB Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-usb/0 linux-usb/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-usb linux-usb/ https://lore.kernel.org/linux-usb \
		linux-usb@vger.kernel.org
	public-inbox-index linux-usb

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-usb


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git