Linux-USB Archive on lore.kernel.org
 help / color / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Ikjoon Jang <ikjn@chromium.org>
Cc: Johan Hovold <johan@kernel.org>,
	linux-usb@vger.kernel.org,
	GregKroah-Hartman <gregkh@linuxfoundation.org>,
	RobHerring <robh+dt@kernel.org>,
	MarkRutland <mark.rutland@arm.com>,
	AlanStern <stern@rowland.harvard.edu>,
	SuwanKim <suwan.kim027@gmail.com>,
	"GustavoA . R . Silva" <gustavo@embeddedor.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Nicolas Boichat <drinkcat@chromium.org>
Subject: Re: [PATCH v4 2/2] usb: overridable hub bInterval by device node
Date: Thu, 5 Dec 2019 15:26:41 +0100
Message-ID: <20191205142641.GL10631@localhost> (raw)
In-Reply-To: <CAATdQgBcuJenS2VSm+y4Yhn5mWE1P0CGJQ3NRdoe68dd2SRPGg@mail.gmail.com>

On Thu, Dec 05, 2019 at 03:32:38PM +0800, Ikjoon Jang wrote:
> On Wed, Dec 4, 2019 at 3:55 PM Johan Hovold <johan@kernel.org> wrote:

> > But related to my question above, why do you need to do this during
> > enumeration? Why not just set the lower interval value in the hub
> > driver?
> 
> Because I want device tree's bInterval to be checked against the same rules
> defined in usb_parse_endpoint(). e.g. although hardware says its maximum
> is 255, but the practical limit is still 0 to 16, so the code can
> print warnings when bInterval from device node is too weird.

But that could be handled refactoring the code in question or similar.

The fundamental problem here is that you're using devicetree, which is
supposed to only describe the hardware, to encode policy which should be
deferred to user space.

So I think you need to figure out an interface that allows user space to
set the polling interval for any hub at runtime instead.

Johan

  reply index

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-03 10:15 Ikjoon Jang
2019-12-03 15:23 ` Alan Stern
2019-12-04  7:07   ` Ikjoon Jang
2019-12-03 16:53 ` Johan Hovold
2019-12-04  7:04   ` Ikjoon Jang
2019-12-04  7:55     ` Johan Hovold
2019-12-05  7:32       ` Ikjoon Jang
2019-12-05 14:26         ` Johan Hovold [this message]
2019-12-06  3:57           ` Ikjoon Jang
2019-12-06 15:00             ` Alan Stern
2019-12-09  3:47               ` Ikjoon Jang
2019-12-06 15:26             ` Johan Hovold
2019-12-09  4:05               ` Ikjoon Jang
2019-12-10 15:02                 ` Johan Hovold

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191205142641.GL10631@localhost \
    --to=johan@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=drinkcat@chromium.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=gustavo@embeddedor.com \
    --cc=ikjn@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=stern@rowland.harvard.edu \
    --cc=suwan.kim027@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-USB Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-usb/0 linux-usb/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-usb linux-usb/ https://lore.kernel.org/linux-usb \
		linux-usb@vger.kernel.org
	public-inbox-index linux-usb

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-usb


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git