From: David Sterba <dsterba@suse.cz>
To: David Howells <dhowells@redhat.com>
Cc: torvalds@linux-foundation.org,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Peter Zijlstra <peterz@infradead.org>,
raven@themaw.net, Christian Brauner <christian@brauner.io>,
keyrings@vger.kernel.org, linux-usb@vger.kernel.org,
linux-block@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL] pipe: Notification queue preparation
Date: Thu, 5 Dec 2019 18:21:27 +0100 [thread overview]
Message-ID: <20191205172127.GW2734@suse.cz> (raw)
In-Reply-To: <1593.1575554217@warthog.procyon.org.uk>
On Thu, Dec 05, 2019 at 01:56:57PM +0000, David Howells wrote:
> David Sterba <dsterba@suse.cz> wrote:
>
> > [<0>] pipe_write+0x1be/0x4b0
>
> Can you get me a line number of that? Assuming you've built with -g, load
> vmlinux into gdb and do "i li pipe_write+0x1be".
I built it with -g (DEBUG_INFO) but there's no output for the command (gdb 8.2):
(gdb) i li pipe_write+0x1be
Function "pipe_write+0x1be" not defined.
But the address can tell something:
(gdb) l *(pipe_write+0x1be)
0xffffffff81390b8e is in pipe_write (fs/pipe.c:509).
warning: Source file is more recent than executable.
504 kill_fasync(&pipe->fasync_readers, SIGIO, POLL_IN);
505 do_wakeup = 0;
506 }
507 pipe->waiting_writers++;
508 pipe_wait(pipe);
509 pipe->waiting_writers--;
510 }
511 out:
512 __pipe_unlock(pipe);
513 if (do_wakeup) {
I rerun the test again (with a different address where it's stuck), there's
nothing better I can get from the debug info, it always points to pipe_wait,
disassembly points to:
0xffffffff81390b71 <+417>: jne 0xffffffff81390c23 <pipe_write+595>
0xffffffff81390b77 <+423>: test %ecx,%ecx
0xffffffff81390b79 <+425>: jne 0xffffffff81390b95 <pipe_write+453>
0xffffffff81390b7b <+427>: addl $0x1,0x110(%rbx)
0xffffffff81390b82 <+434>: mov %rbx,%rdi
0xffffffff81390b85 <+437>: callq 0xffffffff813908c0 <pipe_wait>
0xffffffff81390b8a <+442>: subl $0x1,0x110(%rbx)
(pipe_write+0x1ba == 0xffffffff81390b8a)
next prev parent reply other threads:[~2019-12-05 17:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-25 22:39 [GIT PULL] pipe: Notification queue preparation David Howells
2019-11-30 23:05 ` pr-tracker-bot
2019-12-05 12:58 ` David Sterba
2019-12-05 13:56 ` David Howells
2019-12-05 17:12 ` Linus Torvalds
2019-12-05 17:24 ` Linus Torvalds
2019-12-05 17:21 ` David Sterba [this message]
2019-12-05 17:33 ` Linus Torvalds
2019-12-05 17:25 ` David Howells
2019-12-05 18:18 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191205172127.GW2734@suse.cz \
--to=dsterba@suse.cz \
--cc=christian@brauner.io \
--cc=dhowells@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=peterz@infradead.org \
--cc=raven@themaw.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).