From: Bin Liu <b-liu@ti.com>
To: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-usb <linux-usb@vger.kernel.org>,
Sekhar Nori <nsekhar@ti.com>, Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH] musb: davinci: Convert to use GPIO descriptor
Date: Mon, 9 Dec 2019 11:23:39 -0600 [thread overview]
Message-ID: <20191209172339.GB26131@uda0271908> (raw)
In-Reply-To: <CAMpxmJWRbQOFP_Ftq7q89P-f=3A3Q_wCKaRv6Zki=UJPsPqjvg@mail.gmail.com>
On Mon, Dec 09, 2019 at 11:41:29AM +0100, Bartosz Golaszewski wrote:
> pon., 9 gru 2019 o 01:25 Linus Walleij <linus.walleij@linaro.org> napisał(a):
> >
> > On Thu, Dec 5, 2019 at 9:20 PM Bin Liu <b-liu@ti.com> wrote:
> > > On Thu, Dec 05, 2019 at 03:22:00PM +0100, Linus Walleij wrote:
> > > > The DaVinci MUSB glue contains an optional GPIO line to
> > > > control VBUS power, convert this to use a GPIO descriptor
> > > > and augment the EVM board file to provide this descriptor.
> > > >
> > > > I can't get this driver to compile properly and it depends
> > > > on broken but when I didn get it to compile brokenly, it
> > > > did at least not complain about THIS code being broken so
> > > > I don't think I broke the driver any more than what it
> > > > already is.
> > > >
> > > > I did away with the ifdefs that do not work with
> > > > multiplatform anyway so the day someone decides to
> > > > resurrect the code, the path to get it working should be
> > > > easier as well since DaVinci is now multiplatform.
> > >
> > > Generally I don't take such patches unless they are part of the effort
> > > to un-broken the driver. But is this patch a prerequisite of any cleanup
> > > in DaVinci family or ARM architecture? What is the motivation of this
> > > patch?
> >
> > The motivation is the clean-up of the internal GPIO API for the
> > kernel. It is described in drivers/gpio/TODO
> >
> > I can propose a patch simply deleting the code if you prefer that,
> > then whoever want to resurrect it can still get it out of git if
> > they need. As long as nothing includes <linux/gpio.h> anymore,
> > I am happy.
> >
> > Yours,
> > Linus Walleij
>
> I have a related WiP series that removes calls to legacy GPIO API from
> the dm355-evm which uses the same driver. Hopefully this week I'll
> have some time to take a look at it, especially since I've got the
> relevant HW now. Who knows, maybe I'll even resurrect this code. :)
>
> In other words: please hold off removing of this driver.
Sounds good. I will review and consider taking this patch then. Thanks.
-Bin.
next prev parent reply other threads:[~2019-12-09 17:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-05 14:22 [PATCH] musb: davinci: Convert to use GPIO descriptor Linus Walleij
2019-12-05 20:19 ` Bin Liu
2019-12-09 0:25 ` Linus Walleij
2019-12-09 10:41 ` Bartosz Golaszewski
2019-12-09 17:23 ` Bin Liu [this message]
2019-12-11 0:41 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191209172339.GB26131@uda0271908 \
--to=b-liu@ti.com \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-usb@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).