From: Greg KH <gregkh@linuxfoundation.org>
To: Jayshri Pawar <jpawar@cadence.com>
Cc: linux-usb@vger.kernel.org, felipe.balbi@linux.intel.com,
heikki.krogerus@linux.intel.com, rogerq@ti.com,
linux-kernel@vger.kernel.org, jbergsagel@ti.com, nsekhar@ti.com,
nm@ti.com, peter.chen@nxp.com, kurahul@cadence.com,
pawell@cadence.com, sparmar@cadence.com
Subject: Re: [RFC PATCH] usb:gadget: Fixed issue with config_ep_by_speed function.
Date: Tue, 10 Dec 2019 11:22:31 +0100 [thread overview]
Message-ID: <20191210102231.GA3698263@kroah.com> (raw)
In-Reply-To: <1575284847-3388-1-git-send-email-jpawar@cadence.com>
On Mon, Dec 02, 2019 at 12:07:27PM +0100, Jayshri Pawar wrote:
> /**
> * config_ep_by_speed() - configures the given endpoint
> @@ -144,9 +146,11 @@ next_ep_desc(struct usb_descriptor_header **t)
> */
> int config_ep_by_speed(struct usb_gadget *g,
> struct usb_function *f,
> - struct usb_ep *_ep)
> + struct usb_ep *_ep,
> + unsigned alt)
Why did you not document this new parameter? It does not make sense to
me, what does it do, and how is it supposed to be used?
thanks,
greg k-h
next prev parent reply other threads:[~2019-12-10 10:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-02 11:07 [RFC PATCH] usb:gadget: Fixed issue with config_ep_by_speed function Jayshri Pawar
2019-12-04 7:57 ` Peter Chen
2019-12-10 10:22 ` Greg KH [this message]
2019-12-10 10:30 ` Jayshri Dajiram Pawar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191210102231.GA3698263@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=felipe.balbi@linux.intel.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=jbergsagel@ti.com \
--cc=jpawar@cadence.com \
--cc=kurahul@cadence.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nm@ti.com \
--cc=nsekhar@ti.com \
--cc=pawell@cadence.com \
--cc=peter.chen@nxp.com \
--cc=rogerq@ti.com \
--cc=sparmar@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).