From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5B93C00523 for ; Wed, 8 Jan 2020 04:07:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8A58F2087F for ; Wed, 8 Jan 2020 04:07:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578456436; bh=VtZDsDEpwz+n4uP+f5e+0gPqa19onC19Eezd4Lm0vnE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=YlZXNkqGuNtXh5nXVbbnQrTiWDQz7PR39rlsDwG9fyPs5D5OMgacAjgsoSuEVHgOn SurXz7dWIhuD6YbzOzcS+5IbSZd6fdRWSHe4JYBcKdqN+9MbtWZ3vH18aMk4fD+BUA pZMj0GmbAahu1msCtoTWOBvc42bC3FRDpHAI3UUo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726276AbgAHEHM (ORCPT ); Tue, 7 Jan 2020 23:07:12 -0500 Received: from mail.kernel.org ([198.145.29.99]:44078 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726142AbgAHEHM (ORCPT ); Tue, 7 Jan 2020 23:07:12 -0500 Received: from localhost (unknown [122.167.102.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 432B12070A; Wed, 8 Jan 2020 04:07:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578456432; bh=VtZDsDEpwz+n4uP+f5e+0gPqa19onC19Eezd4Lm0vnE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RZ+58PD4BE+wkzl8l9mi1tHfylBa/A3LY5uWdWymS+Gv2ss3a1SVkjWtp4wSMyTx1 HmhCM1uAt0Nl/H6QUUzQ5GDCHsbq6wK46D2UZdoHt+mAgBO+Cf92A2CZ6It1gnk+kS wiBpYHqpHdFc8yiD03qvkImxv+gwXPivGp0pDFN8= Date: Wed, 8 Jan 2020 09:37:07 +0530 From: Vinod Koul To: John Stultz , Greg Kroah-Hartman Cc: Mathias Nyman , linux-arm-msm@vger.kernel.org, Bjorn Andersson , Yoshihiro Shimoda , Christian Lamparter , linux-usb@vger.kernel.org, Linux Kernel Mailing List , Todd Kjos , Alistair Delva Subject: Re: [PATCH v5 0/4] usb: xhci: Add support for Renesas USB controllers Message-ID: <20200108040707.GU2818@vkoul-mobl> References: <20191106083843.1718437-1-vkoul@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Hi John, On 07-01-20, 11:51, John Stultz wrote: > On Wed, Nov 6, 2019 at 12:40 AM Vinod Koul wrote: > > > > This series add support for Renesas USB controllers uPD720201 and uPD720202. > > These require firmware to be loaded and in case devices have ROM those can > > also be programmed if empty. If ROM is programmed, it runs from ROM as well. > > > > This includes two patches from Christian which supported these controllers > > w/o ROM and later my patches for ROM support and multiple firmware versions. > > > > Hey Vinod! > In pushing this series to one of the Android trees for the db845c, > there was some concern raised that this series is adding a lot of > renesas specific logic to the more generic xhci-pci driver. There was > some question if instead that logic should be added to its own > file/module? Do you have any thoughts on this? TBH I have not thought about that and in previous post neither Greg or Mathias gave a feedback that this was not acceptable... We can think about splitting but apart from firmware load there is not much extra functionality that we need to add, the controller behaviour as a standard xhci-pci. So i am not sure if we gain much by splitting. > Also, It seems there hasn't been much feedback on this for a few > months now. Is there a newer version of the patchset I should sync > with? Do you have plans to resubmit soon? Well am still waiting for feedback :( I dont have any update on top of this, I can repost but I dont think that really serves a purpose. I would really like to hear from Greg if this series is acceptable and if not what would he like to see changed. Thanks -- ~Vinod