From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C89C0C3F68F for ; Mon, 13 Jan 2020 18:26:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A8D552075B for ; Mon, 13 Jan 2020 18:26:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728879AbgAMS0D (ORCPT ); Mon, 13 Jan 2020 13:26:03 -0500 Received: from mail.kernel.org ([198.145.29.99]:49984 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726878AbgAMS0D (ORCPT ); Mon, 13 Jan 2020 13:26:03 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 73E24214AF; Mon, 13 Jan 2020 18:26:02 +0000 (UTC) Date: Mon, 13 Jan 2020 19:26:00 +0100 From: Greg KH To: Johan Hovold Cc: Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, stable , Lubomir Rintel Subject: Re: [PATCH] media: usbtv: fix control-message timeouts Message-ID: <20200113182600.GG411698@kroah.com> References: <20200113171818.30715-1-johan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200113171818.30715-1-johan@kernel.org> Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Mon, Jan 13, 2020 at 06:18:18PM +0100, Johan Hovold wrote: > The driver was issuing synchronous uninterruptible control requests > without using a timeout. This could lead to the driver hanging on > various user requests due to a malfunctioning (or malicious) device > until the device is physically disconnected. > > The USB upper limit of five seconds per request should be more than > enough. > > Fixes: f3d27f34fdd7 ("[media] usbtv: Add driver for Fushicai USBTV007 video frame grabber") > Fixes: c53a846c48f2 ("[media] usbtv: add video controls") > Cc: stable # 3.11 > Cc: Lubomir Rintel > Signed-off-by: Johan Hovold Reviewed-by: Greg Kroah-Hartman