From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96F57C33C9E for ; Wed, 15 Jan 2020 02:44:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6D7A7222C3 for ; Wed, 15 Jan 2020 02:44:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728890AbgAOCor (ORCPT ); Tue, 14 Jan 2020 21:44:47 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:51694 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728862AbgAOCor (ORCPT ); Tue, 14 Jan 2020 21:44:47 -0500 Received: from localhost (unknown [8.46.75.2]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 25338158099BF; Tue, 14 Jan 2020 18:44:34 -0800 (PST) Date: Tue, 14 Jan 2020 18:44:27 -0800 (PST) Message-Id: <20200114.184427.389937353174651227.davem@davemloft.net> To: johan@kernel.org Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, hayeswang@realtek.com Subject: Re: [PATCH] r8152: add missing endpoint sanity check From: David Miller In-Reply-To: <20200114082729.24063-1-johan@kernel.org> References: <20200114082729.24063-1-johan@kernel.org> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 14 Jan 2020 18:44:46 -0800 (PST) Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org From: Johan Hovold Date: Tue, 14 Jan 2020 09:27:29 +0100 > Add missing endpoint sanity check to probe in order to prevent a > NULL-pointer dereference (or slab out-of-bounds access) when retrieving > the interrupt-endpoint bInterval on ndo_open() in case a device lacks > the expected endpoints. > > Fixes: 40a82917b1d3 ("net/usb/r8152: enable interrupt transfer") > Cc: hayeswang > Signed-off-by: Johan Hovold Applied and queued up for -stable, thank you.